Skip to content

[vcpkg] Set CMP0174 NEW#42045

Merged
vicroms merged 2 commits intomicrosoft:masterfrom
dg0yt:cmake-warning
Nov 15, 2024
Merged

[vcpkg] Set CMP0174 NEW#42045
vicroms merged 2 commits intomicrosoft:masterfrom
dg0yt:cmake-warning

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 8, 2024 •
edited
Loading

Fixes #41999.

This PR intentionally forces the new behavior:

  • The relevant spot in vcpkg scripts actually expect the new behavior.
  • Old behaviors are deprecated. vcpkg will eventually adopt the new behavior.
  • No change for users with CMake < 3.31.
    Ports outside vcpkg CI do not need updates unless they really rely on the deprecated behavior AND are used with CMake >=3.31.

Tested locally (with some ports). CI still uses at 3.30.

@dg0yt dg0yt changed the title Fix CMP0174 warning Set CMP0174 NEW Nov 8, 2024
@FrankXie05 FrankXie05 changed the title Set CMP0174 NEW [vcpkg] Set CMP0174 NEW Nov 8, 2024
@FrankXie05 FrankXie05 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Nov 8, 2024
This was referenced Nov 9, 2024
Merged
Merged
@dg0yt dg0yt mentioned this pull request Nov 12, 2024
Merged
@FrankXie05 FrankXie05 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 12, 2024
@xiaozhuai
Copy link
Contributor

xiaozhuai commented Nov 12, 2024 •
edited
Loading 

CMake Deprecation Warning at /opt/vcpkg/scripts/buildsystems/vcpkg.cmake:40 (cmake_policy):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
Call Stack (most recent call first):
  build/binary/arm64-ios-debug/CMakeFiles/3.31.0/CMakeSystem.cmake:6 (include)
  CMakeLists.txt:2 (project)

Please also fix this warning in user project that use cmake >= 3.31
Fixed by #41574

@vicroms vicroms merged commit a4e38a5 into microsoft:master Nov 15, 2024
@dg0yt dg0yt deleted the cmake-warning branch November 16, 2024 07:04
@WangWeiLin-MV WangWeiLin-MV mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@FrankXie05 FrankXie05

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[vcpkg scripts] CMake policy CMP0174 warning from every package with CMake 3.31

4 participants

@dg0yt @xiaozhuai @FrankXie05 @vicroms