[sdl3] Adding port for SDL3 Pre-release#40867
[sdl3] Adding port for SDL3 Pre-release#40867JavierMatosD merged 28 commits intomicrosoft:masterfrom
Conversation
|
All features passed with |
|
I confirmed that SDL2 and SDL3 can be concurrently installed. |
BillyONeal
left a comment
There was a problem hiding this comment.
I think the port is good, thanks for the new port!
I would like to double check with other maintainers that we are OK with merging a port with no upstream releases yet; they might not be wanting people to treat it as generally available, and publishing it in vcpkg might do that. To that end it might be good to use version-string and the git SHA instead, as ensuring reasonable sort order with other prerelease commits sounds questionable.
If there's a statement from upstream maintainers that they're happy with this that avoids all concerns.
Thanks again!
|
Totally! Ill file an issue on their repo and see what they say 😁 The git SHA is a good idea I can do that. |
|
Does this require any other changes? |
BillyONeal
left a comment
There was a problem hiding this comment.
@JavierMatosD Do you know why you asked for team review?
I'm asking for team review since these default features seem to enable APIs which is against our current policy. We accepted the sdl2 port's default-features but I think this was done erroneously or the policy was different when it was added. |
|
As of libsdl-org/SDL#11310, SDL fails to build on Linux if neither X11 or Wayland is enabled |
|
Any ETA on this? |
|
MERGE plz 🔥 |
882a0f3
|
To go along with this - are there any plans to add the SDL3 version of SDL_mixer and SDL_image? |
|
I do have an sdl3 mixer port I can try to upstream. Not sure if that or SDL3_Image have had an ABI lock and a prerelease tag cut though |
|
I do not have an SDL3_image port since i havent needed it |
|
Only SDL3 is in API/ABI lock. None of SDL's satellite libraries are considered stable at this moment. |
|
Thanks for the clarification 😁 |
|
This new port has uncontrolled dependencies with installation order problems. For example, it fails with hidapi and static libusb installed on android. This affects vcpkg CI (e.g. #42045). There may be more issues, but due to I also see copies of khronos headers which have ports in vcpkg. |
|
The import prefix fails on ubuntu, because the config cmake is in Edit: I was able to fix this using a patched overlay port, with this patch on root SDL3 CMakeLists.txt |
That's the wrong location, indeed. But my diagnose is a little bit different. #42206. |
Citing #32062 and the fact that the new SDL3 MkII GPU API got some buzz I thought people might find an SDL3 port useful. I've been using this port myself for a little while so figured I'd try up-streaming it. Should be easy to update this port for the full SDL 3.0.0 release
Note: SDL3 has dropped support for UWP so it has been removed from
supports😞find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.