Regarding "Contribution License Agreement" I am unclear on what is being targeted there? Is it solely the commits on this repo, or are they referring to the package's source code being packaged?

Regarding "Contribution License Agreement" I am unclear on what is being targeted there? Is it solely the commits on this repo, or are they referring to the package's source code being packaged?

I am not a lawyer but my understanding is that it applies to your contributions to the repo.

Please feel free to click 'ready for review' if you accept the CLA and fix build failures.

@microsoft-github-policy-service agree

usage:

spglib provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(Spglib CONFIG REQUIRED)
  target_link_libraries(main PRIVATE Spglib::symspg Spglib::fortran)

spglib provides pkg-config modules:

  # The spglib library
  spglib

When testing usage, the following error occurs:

1> [CMake] CMake Error at test/CMakeLists.txt:7 (target_link_libraries):
1> [CMake]   Target "main" links to:
1> [CMake] 
1> [CMake]     Spglib::fortran
1> [CMake] 
1> [CMake]   but the target was not found.  Possible reasons include:
1> [CMake] 
1> [CMake]     * There is a typo in the target name.
1> [CMake]     * A find_package call is missing for an IMPORTED target.
1> [CMake]     * An ALIAS target is missing.

#include <iostream>
#include "spglib.h"
using namespace std;
int main()

{

cout << "Hello CMake." << endl;

return 0;

}

cmake_minimum_required (VERSION 3.8)
set(CMAKE_TOOLCHAIN_FILE "G:/spg/vcpkg/scripts/buildsystems/vcpkg.cmake")
project ("test")
add_library (main "test.cpp")
find_package(Spglib CONFIG REQUIRED)

target_link_libraries(main PRIVATE Spglib::symspg Spglib::fortran)

usage:

Modern CMake design is to use FetchContent and rely on FIND_PACKAGE_ARGS. spglib was converted to allow this modern workflow. What do you think about advertising that?

Regarding fortran. This is disabled, you should only link to Splib::symspg. Fortran is rather tricky to package because it is ABI incompatible, so it should be installed in compiler specific folders if library files are to be installed for the user. Does vcpkg distribute binaries, or in the process of importing a vcpkg package, is the install step used? If so, how does vcpkg deal with changing compilers (actually this is an issue for C++ as well) and/or caching.

The usage test passed on x64-windows (header files found):

spglib provides CMake targets:

    find_package(Spglib CONFIG REQUIRED)
    target_link_libraries(main PRIVATE Spglib::symspg)

    # spglib is also compatible with modern CMake workflows
    include(FetchContent)
    FetchContent_Declare(Spglib
            GIT_REPOSITORY https://github.com/spglib/spglib
            GIT_TAG develop
    )
    FetchContent_MakeAvailable(Spglib ...)
    target_link_libraries(main PRIVATE Spglib::symspg)

spglib provides pkg-config modules:

    # The spglib library
    spglib

    find_package(Spglib CONFIG REQUIRED)
    target_link_libraries(main PRIVATE Spglib::symspg)

    # spglib is also compatible with modern CMake workflows
    include(FetchContent)
    FetchContent_Declare(Spglib
            GIT_REPOSITORY https://github.com/spglib/spglib
            GIT_TAG develop
    )
    FetchContent_MakeAvailable(Spglib ...)
    target_link_libraries(main PRIVATE Spglib::symspg)

Did you copy the whole block literally to CMakeLists.txt?

Did you copy the whole block literally to CMakeLists.txt?

Yes, I tested the following two ways separately:

    find_package(Spglib CONFIG REQUIRED)
    target_link_libraries(main PRIVATE Spglib::symspg)

    # spglib is also compatible with modern CMake workflows
    include(FetchContent)
    FetchContent_Declare(Spglib
            GIT_REPOSITORY https://github.com/spglib/spglib
            GIT_TAG develop
    )
    FetchContent_MakeAvailable(Spglib)
    target_link_libraries(main PRIVATE Spglib::symspg)

Should I separate the blocks a bit there, maybe like:

spglib provides CMake targets:

    find_package(Spglib CONFIG REQUIRED)
    target_link_libraries(main PRIVATE Spglib::symspg)

spglib is also compatible with modern CMake workflows

    include(FetchContent)
    FetchContent_Declare(Spglib
            GIT_REPOSITORY https://github.com/spglib/spglib
            GIT_TAG develop
            FIND_PACKAGE_ARGS CONFIG
    )
    FetchContent_MakeAvailable(Spglib ...)
    target_link_libraries(main PRIVATE Spglib::symspg)

I believe this point is valuable to document because not all projects are FetchContent compatible, and this is a recommended workflow to migrate towards. But if this continues to be a controversial issue, I will concede on the topic.

Your FetchContent implementation may be excellent, but that approach really doesn't integrate well with vcpkg's effort to control version, configuration and ABI. Simply remove the section which is unrelated to the vcpgk port.

Your FetchContent implementation may be excellent, but that approach really doesn't integrate well with vcpkg's effort to control version, configuration and ABI.

What I am trying to say is that it does integrate. I encourage you to try it out, particularly see the instructions here and look at the build directory and the presence/absence of _deps folder. Also, follow this and this upstream issues about the plans to further migrate these interfaces.

it does integrate

It integrate well with CMake but not with vcpkg IMO.

vcpkg makes an installation plan for installing dependencies for the top-level manifest (or command line), considering triplets, features, registries, overlay ports, version constraints. This determines which "spglib" to use. If the user project chooses, or falls back to, FetchContent, it is likely to result in another version and configuration than the one used by ports, and other than defined in the top-level manifest. The result may fail at build time or at runtime, in obvious or subtle ways.

If the user project chooses, or falls back to, FetchContent, it is likely to result in another version and configuration than the one used by ports, and other than defined in the top-level manifest.

Setting CMAKE_REQUIRE_FIND_PACKAGE_Spglib would guarantee only find_package is considered. And dependency provider is the CMake recommended approach to give vcpkg full control.