[openblas] Fix build errors on osx by jimwang118 · Pull Request #36072 · microsoft/vcpkg

jimwang118 · 2024-01-08T09:54:48Z

ld: error: undefined symbol: cabsf
>>> referenced by c_cblat2c.c:3566 (/home/CORP/b.manganelli/Projects/vcpkg/buildtrees/openblas/src/v0.3.25-dc6d649124.clean/ctest/c_cblat2c.c:3566)
>>>               ctest/CMakeFiles/xccblat2.dir/c_cblat2c.c.o:(cmvch_)

Changes comply with the maintainer guide
~~SHA512s are updated for each updated download~~
~~The "supports" clause reflects platforms that may be fixed by this new version~~
~~Any fixed CI baseline entries are removed from that file.~~
~~Any patches that are no longer applied are deleted from the port's directory.~~
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x64-windows
x64-osx

…openblas

…to fix_openblas

dg0yt

Unrelated to this PR: The port doesn't correctly acquire git (if needed at all) and sed.

ports/openblas/portfile.cmake

bmanga · 2024-01-09T10:25:58Z

ports/openblas/portfile.cmake

 if(VCPKG_TARGET_IS_OSX)
+    list(APPEND COMMON_OPTIONS -DONLY_CBLAS=1)


Does this change also make it work for android?

Added option separately for Android.

Added option separately for Android.

Did you test it? Android is skipped in ci.baseline.

@dg0yt When I test on local Android, the following error occurs. My local environment is an Android environment built under Linux.
When cross compiling, a TARGET is required.
@bmanga Can you help with testing on your Android environment?

So you were adding untested changes...
I prefer to start with logs from vcpkg CI before spending local build time.

The conclusion is wrong. Only arm64 and arm are detected. For others, you are asked to define TARGET.
And I only ask that the android shall be tested before merged. If possible, by removing the ci.baseline entries.

Possible targets are found here:
https://github.com/OpenMathLib/OpenBLAS/blob/d6a5174e9c50b9f68db96d7d7818f92cdfb4e7ec/TargetList.txt
The (Android x64) task is to make a reasonable choice in the portfile. And the user may even override in the triplet file.

I queried the CPU model of the device, but it was not in the support list provided by xxx and therefore could not be tested.
16 AMD EPYC 7452 32-Core Processor

@jimwang118 this PR works for me, thanks

Thanks for testing.

jimwang118 · 2024-01-29T02:01:31Z

/azp run

azure-pipelines · 2024-01-29T02:01:40Z

Azure Pipelines successfully started running 1 pipeline(s).

bmanga · 2024-02-16T13:25:29Z

Any updates on this?

Passing on https://dev.azure.com/vcpkg/public/_build/results?buildId=99959&view=results. Added `openblas` to ci.baseline.txt by #29406, which has been fixed by #36072: ``` PASSING, REMOVE FROM FAIL LIST: openblas:arm-neon-android PASSING, REMOVE FROM FAIL LIST: openblas:arm64-android ``` Add the following ports to the ci.baseline.txt because they are direct/indirect downstream of `openblas`: ``` REGRESSION: blas:arm-neon-android failed with BUILD_FAILED. If expected, add blas:arm-neon-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt. REGRESSION: lapack-reference:arm64-android failed with BUILD_FAILED. If expected, add lapack-reference:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt. REGRESSION: clapack:arm64-android failed with BUILD_FAILED. If expected, add clapack:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt. REGRESSION: shogun:arm64-android failed with BUILD_FAILED. If expected, add shogun:arm64-android=fail to /vcpkg/scripts/azure-pipelines/../ci.baseline.txt. ``` - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [ ] ~SHA512s are updated for each updated download.~ - [x] The "supports" clause reflects platforms that may be fixed by this new version. - [ ] ~Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file.~ - [ ] ~Any patches that are no longer applied are deleted from the port's directory.~ - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file. --------- Co-authored-by: Monica <[email protected]>

jimwang118 added 2 commits January 8, 2024 17:49

fix build errors on osx

b52d612

update version

f0accd6

jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jan 8, 2024

jimwang118 assigned Cheney-W Jan 8, 2024

jimwang118 and others added 4 commits January 9, 2024 10:42

Merge branch 'master' of https://github.com/microsoft/vcpkg into fix_…

cbf0dc8

…openblas

static

b1be68f

update version

7bd2ced

Merge branch 'fix_openblas' of https://github.com/jimwang118/vcpkg in…

2384e87

…to fix_openblas

dg0yt reviewed Jan 9, 2024

View reviewed changes

ports/openblas/portfile.cmake Outdated Show resolved Hide resolved

jimwang118 added 2 commits January 9, 2024 15:17

add option

9666ad1

update version

3391d2f

bmanga reviewed Jan 9, 2024

View reviewed changes

jimwang118 added 2 commits January 10, 2024 10:06

android

f122f33

update version

72394f4

jimwang118 marked this pull request as ready for review January 11, 2024 02:05

jimwang118 marked this pull request as draft January 11, 2024 08:52

Merge branch 'master' into fix_openblas

2d8fd4a

jimwang118 added 3 commits February 19, 2024 02:52

solved confilcts

8ee4e99

update version

1acfbee

update version

43d9ea7

jimwang118 marked this pull request as ready for review February 20, 2024 07:05

Cheney-W approved these changes Feb 26, 2024

View reviewed changes

Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 26, 2024

vicroms merged commit 3dd44b9 into microsoft:master Feb 27, 2024

MonicaLiu0311 mentioned this pull request Mar 1, 2024

[vcpkg baseline][openblas] Passing remove form fail list #37056

Merged

7 tasks

		if(VCPKG_TARGET_IS_OSX)
		list(APPEND COMMON_OPTIONS -DONLY_CBLAS=1)

Conversation

jimwang118 commented Jan 8, 2024

Uh oh!

dg0yt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jimwang118 commented Jan 29, 2024

Uh oh!

azure-pipelines bot commented Jan 29, 2024

Uh oh!

bmanga commented Feb 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants