Skip to content

[alsa] Add cmake wrapper#30960

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
FtZPetruska:alsa-add-wrapper
Apr 20, 2023
Merged

[alsa] Add cmake wrapper#30960
BillyONeal merged 2 commits intomicrosoft:masterfrom
FtZPetruska:alsa-add-wrapper

Conversation

@FtZPetruska
Copy link
Contributor

@FtZPetruska FtZPetruska commented Apr 19, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

The FindALSA module provided by Kitware does not search for the transitive usage requirements (namely libm, libdl, pthread, and librt). Depending on the system, it may lead to failures when linking statically (see #30625 (comment)).

This PR checks for each library in the order they typically appear in the pkg-config file and adds them to the ALSA_LIBRARIES list and ALSA::ALSA's INTERFACE_LINK_LIBRARIES.

Additionally, the wrapper sets the available configurations (debug/release) for the target.

cc @BillyONeal

@FtZPetruska
[alsa] Add cmake wrapper.
98f8034 
This adds the imported location for both Debug and Release
configurations, and sets the target's INTERFACE_LINK_LIBRARIES and the
ALSA_LIBRARIES variable to the same libraries as the pkg-config file.
@FtZPetruska
[alsa] Update baseline.
da53606
@jimwang118 jimwang118 self-assigned this Apr 19, 2023
BillyONeal
BillyONeal approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to submit this upstream at https://gitlab.kitware.com/cmake/cmake/-/issues ?

@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 20, 2023
@jimwang118
Copy link
Contributor

jimwang118 commented Apr 20, 2023

The usage has been tested successfully locally.

@jimwang118 jimwang118 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 20, 2023
@FtZPetruska
Copy link
Contributor Author

FtZPetruska commented Apr 20, 2023

Does it make sense to submit this upstream at https://gitlab.kitware.com/cmake/cmake/-/issues ?

Since it's technically not an issue only for vcpkg (although typically, Linux distributions favour shared builds over static so would be unaffected), I went ahead an opened an issue upstream about it https://gitlab.kitware.com/cmake/cmake/-/issues/24835.

@BillyONeal BillyONeal merged commit 72d359a into microsoft:master Apr 20, 2023
@BillyONeal
Copy link
Member

BillyONeal commented Apr 20, 2023

Thanks for submitting upstream!

@FtZPetruska FtZPetruska deleted the alsa-add-wrapper branch April 21, 2023 02:01
@FtZPetruska FtZPetruska mentioned this pull request Apr 21, 2023
Merged
7 tasks
@Cheney-W Cheney-W mentioned this pull request Apr 27, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@jimwang118 jimwang118

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FtZPetruska @jimwang118 @BillyONeal