[libcoro] New Port by chausner · Pull Request #30623 · microsoft/vcpkg

chausner · 2023-04-02T18:43:32Z

This adds libcoro 0.9 as a new port.

This library does not support Windows. Also, CI builds x64-osx are disabled because the GCC compiler version is too old.

scripts/ci.baseline.txt

ports/libcoro/portfile.cmake

chausner · 2023-04-03T18:40:20Z

I am wondering if we should include !osx in supports given that Clang is not supported by the library and it is the default compiler on macOS? The library itself might be compatible to macOS, though, if a recent version of gcc is used.

vicroms · 2023-04-05T23:56:23Z

As it is, the library is not being tested in any way in CI.
We should wait to merge until a VM update allows us to test this (at least on Linux).

Upstream requirements

    g++10.2.1
    g++10.3.1

Track: microsoft/azure-pipelines-agent#3834

FrankXie05 · 2023-05-09T03:08:09Z

Waiting for the vm to update, temporarily turning to draft status. Once the update is complete, it will be retested.

dg0yt · 2023-08-06T14:34:10Z

@chausner Could you please sync the branch master? :)

Done! But it seems some of the CI builds are stuck..

Just add an empty commit to restart them.

chausner · 2023-08-06T23:41:46Z

@chausner Could you please sync the branch master? :)

Done! But it seems some of the CI builds are stuck..

Just add an empty commit to restart them.

Done. The x64_linux pipeline failed due to some unrelated build error of llvm.

FrankXie05 · 2023-08-07T07:26:10Z

/azp run

azure-pipelines · 2023-08-07T07:26:20Z

Azure Pipelines successfully started running 1 pipeline(s).

FrankXie05 · 2023-08-07T08:38:22Z

/usr/include/c++/11/atomic: In member function ‘bool std::atomic<_Tp>::compare_exchange_weak(_Tp&, _Tp, std::memory_order, std::memory_order)’:
/usr/include/c++/11/atomic:323:9: error: there are no arguments to ‘__is_valid_cmpexch_failure_order’ that depend on a template parameter, so a declaration of ‘__is_valid_cmpexch_failure_order’ must be available [-fpermissive]
  323 |         __glibcxx_assert(__is_valid_cmpexch_failure_order(__f));
      |         ^~~~~~~~~~~~~~~~

install-x64-linux-dbg-out.log

It seems that it is still due to the problem of gcc version. cc @BillyONeal @vicroms

chausner · 2023-09-24T08:57:01Z

@FrankXie05 Could you please have another look? I updated the library to 0.9 and it appears to succeed in CI now. The two errors in CI seem unrelated:

REGRESSION: pmdk:x64-linux is marked as fail but not supported for x64-linux.
REGRESSION: kf5kio:x64-linux failed with BUILD_FAILED. If expected, add kf5kio:x64-linux=fail to /mnt/vss/_work/1/s/scripts/azure-pipelines/../ci.baseline.txt.

dg0yt · 2023-09-24T10:27:07Z

REGRESSION: pmdk:x64-linux is marked as fail but not supported for x64-linux.

#33766 (comment)

FrankXie05 · 2023-09-25T02:44:47Z

/azp run

azure-pipelines · 2023-09-25T02:44:57Z

Azure Pipelines successfully started running 1 pipeline(s).

ports/libcoro/portfile.cmake

ports/libcoro/vcpkg.json

versions/l-/libcoro.json

vicroms · 2023-09-29T06:37:32Z

/azp run

azure-pipelines · 2023-09-29T06:37:41Z

Azure Pipelines successfully started running 1 pipeline(s).

* Add libcoro 0.7 * Update CI baseline * Add "supports": "!windows" * Update CI baseline * Remove unneeded vcpkg-cmake-config dependency * Update CI baseline * Disable x64-linux and x64-osx in ci.baseline.txt * Apply code review suggestions * Update CI baseline * Add patch to disable git config * Update CI baseline * Fix patch * Update CI baseline * Allow shared library builds * Update CI baseline * Update libcoro to version 0.8 * Update CI baseline * Update CI baseline * Fix line endings * Update CI baseline * Fix hash * Update CI baseline * Update version database * Force rerun of CI pipeline * Update to libcoro 0.9 * Update CI baseline * Replace manual dependency check with manifest-based one * Remove v0.8 version * Update CI baseline --------- Co-authored-by: chausner <[email protected]> Co-authored-by: Billy Robert O'Neal III <[email protected]>

Passing on https://dev.azure.com/vcpkg/public/_build/results?buildId=103938&view=results. ``` PASSING, REMOVE FROM FAIL LIST: c4core:arm-neon-android PASSING, REMOVE FROM FAIL LIST: botan:arm-neon-android PASSING, REMOVE FROM FAIL LIST: concurrencpp:arm-neon-android PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:arm-neon-android PASSING, REMOVE FROM FAIL LIST: graphicsmagick:arm-neon-android PASSING, REMOVE FROM FAIL LIST: libcoro:arm-neon-android PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:arm-neon-android PASSING, REMOVE FROM FAIL LIST: stx:arm-neon-android PASSING, REMOVE FROM FAIL LIST: yoga:arm-neon-android PASSING, REMOVE FROM FAIL LIST: c4core:x64-android PASSING, REMOVE FROM FAIL LIST: botan:x64-android PASSING, REMOVE FROM FAIL LIST: concurrencpp:x64-android PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:x64-android PASSING, REMOVE FROM FAIL LIST: graphicsmagick:x64-android PASSING, REMOVE FROM FAIL LIST: libcoro:x64-android PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:x64-android PASSING, REMOVE FROM FAIL LIST: stx:x64-android PASSING, REMOVE FROM FAIL LIST: yoga:x64-android PASSING, REMOVE FROM FAIL LIST: c4core:arm64-android PASSING, REMOVE FROM FAIL LIST: botan:arm64-android PASSING, REMOVE FROM FAIL LIST: concurrencpp:arm64-android PASSING, REMOVE FROM FAIL LIST: cppgraphqlgen:arm64-android PASSING, REMOVE FROM FAIL LIST: graphicsmagick:arm64-android PASSING, REMOVE FROM FAIL LIST: libcoro:arm64-android PASSING, REMOVE FROM FAIL LIST: ms-ifc-sdk:arm64-android PASSING, REMOVE FROM FAIL LIST: stx:arm64-android PASSING, REMOVE FROM FAIL LIST: yoga:arm64-android ``` Added `c4core` to `ci.baseline.txt` by #29406, which has been fixed by #39287. Added `botan` to `ci.baseline.txt` by #37252, which has been fixed by #38975. Added `concurrencpp` to `ci.baseline.txt` by #29406, which may have been fixed by #39160. Added `cppgraphqlgen` to `ci.baseline.txt` by #29406, which may have been fixed by #38975. Added `graphicsmagick` to `ci.baseline.txt` by #29406, which has been fixed by #39210. Added `libcoro` to `ci.baseline.txt` by #30623, which may have been fixed by #38975. Added `ms-ifc-sdk` to `ci.baseline.txt` by #35972, which may have been fixed by #39210. Added `stx` to `ci.baseline.txt` by #29406, which may have been fixed by #38975. Added `yoga` to `ci.baseline.txt` by #37507, which may have been fixed by #38975.

chausner added 7 commits April 2, 2023 20:36

Add libcoro 0.7

5c28b77

Update CI baseline

5c9c061

Add "supports": "!windows"

6a8bed8

Update CI baseline

c788dcb

Remove unneeded vcpkg-cmake-config dependency

eae9f2a

Update CI baseline

42b0e44

Disable x64-linux and x64-osx in ci.baseline.txt

9a20ac2

MonicaLiu0311 assigned FrankXie05 Apr 3, 2023

FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 3, 2023

FrankXie05 suggested changes Apr 3, 2023

View reviewed changes

scripts/ci.baseline.txt Outdated Show resolved Hide resolved

ports/libcoro/portfile.cmake Outdated Show resolved Hide resolved

FrankXie05 added the requires:author-response label Apr 3, 2023

chausner added 2 commits April 3, 2023 20:34

Apply code review suggestions

b8445c9

Update CI baseline

d8efac5

chausner added 4 commits April 4, 2023 00:36

Add patch to disable git config

0e8735e

Update CI baseline

69583bd

Fix patch

50d143d

Update CI baseline

9cf97fd

chausner marked this pull request as draft April 4, 2023 06:21

MonicaLiu0311 removed the requires:author-response label Apr 4, 2023

chausner added 2 commits April 4, 2023 19:43

Allow shared library builds

dcbb572

Update CI baseline

2c0cb0b

chausner marked this pull request as ready for review April 4, 2023 17:45

chausner mentioned this pull request Apr 12, 2023

Mention Conan in README.md jbaldwin/libcoro#135

Merged

FrankXie05 marked this pull request as draft May 9, 2023 03:08

Force rerun of CI pipeline

5dcdc77

chausner added 3 commits September 24, 2023 00:54

Merge remote-tracking branch 'upstream/master' into libcoro-0.7

dd8058e

Update to libcoro 0.9

9309a56

Update CI baseline

30c455a

chausner dismissed FrankXie05’s stale review via 30c455a September 23, 2023 23:14

FrankXie05 requested review from vicroms and removed request for dg0yt September 27, 2023 02:27

FrankXie05 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 27, 2023

vicroms requested changes Sep 27, 2023

View reviewed changes

ports/libcoro/portfile.cmake Outdated Show resolved Hide resolved

ports/libcoro/vcpkg.json Show resolved Hide resolved

versions/l-/libcoro.json Outdated Show resolved Hide resolved

chausner added 3 commits September 27, 2023 20:45

Replace manual dependency check with manifest-based one

0b67cf5

Remove v0.8 version

ef7ce85

Update CI baseline

c841d54

vicroms approved these changes Sep 29, 2023

View reviewed changes

vicroms merged commit 38dd6b1 into microsoft:master Oct 2, 2023

chausner mentioned this pull request Oct 2, 2023

Mention vcpkg in README.md jbaldwin/libcoro#177

Merged

chausner deleted the libcoro-0.7 branch October 2, 2023 18:29

MonicaLiu0311 mentioned this pull request Jun 17, 2024

[vcpkg baseline][many ports] Passing remove form fail list #39333

Merged

7 tasks

Conversation

chausner commented Apr 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chausner commented Apr 3, 2023

Uh oh!

vicroms commented Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FrankXie05 commented May 9, 2023

Uh oh!

dg0yt commented Aug 6, 2023

Uh oh!

chausner commented Aug 6, 2023

Uh oh!

FrankXie05 commented Aug 7, 2023

Uh oh!

azure-pipelines bot commented Aug 7, 2023

Uh oh!

FrankXie05 commented Aug 7, 2023

Uh oh!

chausner commented Sep 24, 2023

Uh oh!

dg0yt commented Sep 24, 2023

Uh oh!

FrankXie05 commented Sep 25, 2023

Uh oh!

azure-pipelines bot commented Sep 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vicroms commented Sep 29, 2023

Uh oh!

azure-pipelines bot commented Sep 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chausner commented Apr 2, 2023 •

edited

Loading

vicroms commented Apr 5, 2023 •

edited

Loading