@FrankXie05
Please review.

There many modules that are optional. Some of them required matlab or cuda that I don't have to check.

OK then we should patch the build system or set CMAKE_DISABLE_FIND_PACKAGE_Xxx or similar to ensure those detections always say "false" so that people don't get a different thing installed if they happen to have matlab or cuda present on their system. We don't care that every optional knob is available when something is added, just that people don't randomly get extra knobs we haven't tested turned on just because they happened to build on a different machine.

@BillyONeal Chrono just release the 8.0.0 version. So I switch back to 8.

Excellent, thank you!

As far I understand, the optional detection is only activate if I enable the modules. All the module is off by default. You can take a look in their module documentations: https://api.projectchrono.org/development/tutorial_table_of_content_install.html

@BillyONeal Let me know if you agree with me.

As far I understand, the optional detection is only activate if I enable the modules. All the module is off by default. You can take a look in their module documentations: https://api.projectchrono.org/development/tutorial_table_of_content_install.html

@BillyONeal Let me know if you agree with me.

There are many many unguarded find_package calls. Even just looking at 8.0.0-6dccb3d031.clean\src\CMakeLists.txt has:

find_package("TBB")
find_package(SIMD) # Guarded by an on by default option USE_SIMD, there is a port for this
find_package(Eigen3 3.3.0) # OK, an explicit dependency
find_package(MPI)
find_package(CUDA QUIET)
find_package(Thrust)
find_package(HDF5 COMPONENTS CXX) # OK, guarded by off-by-default option ENABLE_HDF5

This stuff needs to not build a subtly different package because someone happens to have some of these installed first.

(To clarify, you don't need to mess with every optional dependency that is indeed guarded by an off option. You do, however, need to demonstrate that those are so guarded. Patching more things to be REQUIRED is always going to be appreciated even if they happen to be not touched by that particular build, because it clearly demonstrates that something is, in fact, disabled)

(To clarify, you don't need to mess with every optional dependency that is indeed guarded by an off option. You do, however, need to demonstrate that those are so guarded. Patching more things to be REQUIRED is always going to be appreciated even if they happen to be not touched by that particular build, because it clearly demonstrates that something is, in fact, disabled)

I will create a patch.

@BillyONeal Please review.