[vcpkg tool] Add optional tracing of find_package#27982
Merged
JavierMatosD merged 3 commits intomicrosoft:masterfrom Dec 1, 2022
Merged
[vcpkg tool] Add optional tracing of find_package#27982JavierMatosD merged 3 commits intomicrosoft:masterfrom
find_package#27982JavierMatosD merged 3 commits intomicrosoft:masterfrom
Conversation
find_packagefind_package
LilyWangLL
previously approved these changes
Nov 24, 2022
7defad4
Contributor
|
Thank you, @dg0yt for the PR and for splitting the PR! It makes it much easier to review. :) |
This was referenced Dec 4, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
This is the less controversial part of [vcpkg] Controlling top-level find_package #27950: Tracing find_package.
With complex projects such as gdal, it is really difficult to see all calls to find_package and to understand side effects of
CMAKE_DISABLE_FIND_PACKAGE_<Pkg>. Output gives no indication of top-level calls vs. nesting (find_dependency), and there is no output at all ifQUIETis used.This PR adds optional tracing output whenever
find_packageis called, indicating nested calls with indentation.It is off by default in order to not change behaviour in user projects, but it could be generally turned on in
vcpkg_cmake_configurefor maintainer convenience.Example: