Skip to content

[opensp] minor fixes, new .pc file#26382

Merged
JavierMatosD merged 6 commits intomicrosoft:masterfrom
wrobelda:opensp_fixes
Aug 19, 2022
Merged

[opensp] minor fixes, new .pc file#26382
JavierMatosD merged 6 commits intomicrosoft:masterfrom
wrobelda:opensp_fixes

Conversation

@wrobelda
Copy link
Contributor

@wrobelda wrobelda commented Aug 16, 2022

  • What does your PR fix?

    • Fixes version missing from .config.h on Windows
    • Installs a .pc file
  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No change

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libopensp have changed but the version was not updated
version: 1.5.2
old SHA: c52391221569480b2e639b0e07a9e809e7711320
new SHA: 501688cdf5633e4af66d1a8a28718c79275883f3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libopensp have changed but the version was not updated
version: 1.5.2
old SHA: c52391221569480b2e639b0e07a9e809e7711320
new SHA: bf9787aef341897999bd77bfb6c234ddb2d4db53
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Aug 16, 2022
@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 17, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 17, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 17, 2022
@wrobelda wrobelda changed the title [opensp] minore fixes, new .pc file [opensp] minor fixes, new .pc file Aug 17, 2022
@wrobelda wrobelda marked this pull request as ready for review August 17, 2022 16:37
@LilyWangLL
Copy link
Contributor

@wrobelda
Copy link
Contributor Author

Please add port-version: 1 to vcpkg.json

Sorry, slipped my mind. Fixed.

@LilyWangLL LilyWangLL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Aug 19, 2022
@JavierMatosD
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants