Skip to content

[Minizip] enable clang-cl builds#25960

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
Neumann-A:minizip_enable_clangcl
Jul 25, 2022
Merged

[Minizip] enable clang-cl builds#25960
BillyONeal merged 4 commits intomicrosoft:masterfrom
Neumann-A:minizip_enable_clangcl

Conversation

@Neumann-A
Copy link
Contributor

No description provided.

github-actions[bot]
github-actions bot previously approved these changes Jul 24, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/minizip/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/minizip/vcpkg.json

Valid values for the license field can be found in the documentation

@Neumann-A Neumann-A changed the title Minizip enable clang-cl builds [Minizip] enable clang-cl builds Jul 24, 2022
@LilyWangLL LilyWangLL self-assigned this Jul 25, 2022
@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 25, 2022
@LilyWangLL
Copy link
Contributor

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions: vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake) vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake) vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake) vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/minizip/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/minizip/vcpkg.json

Valid values for the license field can be found in the documentation

Could you please apply these suggestions?

@Neumann-A
Copy link
Contributor Author

@LilyWangLL done

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/minizip/vcpkg.json

Valid values for the license field can be found in the documentation

@Neumann-A
Copy link
Contributor Author

@LilyWangLL you forgot to remove the author response tag

@BillyONeal BillyONeal merged commit 4ad8fc2 into microsoft:master Jul 25, 2022
@BillyONeal
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants