Skip to content

[lz4] Patch for CVE-2021-3520#25421

Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom
EddyPronk:lz4-patch
Jun 29, 2022
Merged

[lz4] Patch for CVE-2021-3520#25421
dan-shaw merged 2 commits intomicrosoft:masterfrom
EddyPronk:lz4-patch

Conversation

@EddyPronk
Copy link
Copy Markdown
Contributor

  • Fixes potential memory corruption

See https://nvd.nist.gov/vuln/detail/CVE-2021-3520 for more details

This is the upstream patch by Jasper Lievisse Adriaanse.

Commit message of upstream patch: "Fix potential memory corruption with negative memmove() size"
Merged upstream pull request lz4/lz4#972

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No change to triplets.

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

See https://nvd.nist.gov/vuln/detail/CVE-2021-3520 for more details

This is the upstream patch by Jasper Lievisse Adriaanse.

"Fix potential memory corruption with negative memmove() size"
lz4/lz4#972
@ghost
Copy link
Copy Markdown

ghost commented Jun 24, 2022

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jun 24, 2022
@Cheney-W
Copy link
Copy Markdown
Contributor

Please sign the CLA first.

@EddyPronk
Copy link
Copy Markdown
Contributor Author

Please sign the CLA first.

Done. Note that Jasper Lievisse Adriaanse is the author of the upstream patch.

github-actions[bot]
github-actions Bot previously approved these changes Jun 27, 2022
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/lz4/vcpkg.json

Valid values for the license field can be found in the documentation

@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 27, 2022
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for lz4 have changed but the version was not updated
version: 1.9.3#4
old SHA: c0b8b0721a7f78c9cc15b3be583143b4e621ca7f
new SHA: f3b3f8d7799086d118dd166c346665ad71b66c19
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@Cheney-W Cheney-W removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 27, 2022
@Cheney-W
Copy link
Copy Markdown
Contributor

Please run

./vcpkg x-add-version lz4 --overwrite-version
git add .
git commit --amend --no-edit
git push

@EddyPronk
Copy link
Copy Markdown
Contributor Author

Please run

./vcpkg x-add-version lz4 --overwrite-version
git add .
git commit --amend --no-edit
git push

Done. Thanks for your help.

@EddyPronk
Copy link
Copy Markdown
Contributor Author

Please merge this to master. @dan-shaw @Cheney-W

@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 29, 2022
@dan-shaw dan-shaw merged commit 2666dee into microsoft:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants