Skip to content

[many ports] Fix version files#24277

Merged
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
vicroms:pr/fix-wrong-version-hashes
Apr 21, 2022
Merged

[many ports] Fix version files#24277
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
vicroms:pr/fix-wrong-version-hashes

Conversation

@vicroms
Copy link
Member

@vicroms vicroms commented Apr 20, 2022

Fix problems in version files detected by x-ci-verify-versions --verify-git-trees

Ports with versions that are not in our Git history

These are caused when a PR adds multiple versions of a single port to the database in the same PR.

  • color-console
  • cuda
  • directxsdk
  • glad
  • libao
  • libtcod
  • sleepy-discord

Ports with version discrepancies between files in SHA and version declared in DB

These are often caused by bad merges when pulling upstream changes.

  • libarchive
  • mailio
  • opencv3
  • opencv4
  • robin-map

Ports with versions that contain errors on their CONTROL or vcpkg.json file.

  • abseil:2020-03-03#7: features are improperly formatted
    git show 28fa609b06eec70bb06e61891e94b94f35f7d06e:vcpkg.json
  • blend2d:beta_2020_07_31: features are improperly formatted
    git show ffce764b880d8cc24e3b00328aa3861f15bae91d:vcpkg.json
  • libwebp:1.1.0: CONTROL file contains _ that is now disallowed
    git show a05e0de81085231df86f6902aba1e0a364e2ca7b:CONTROL

After all this have been fixed we can enable --verify-git-trees on our CI to prevent these issues from popping up again.

  • Enable --verify-git-trees on CI

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Apr 21, 2022
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 21, 2022
@strega-nil-ms strega-nil-ms merged commit c656e2e into microsoft:master Apr 21, 2022
@vicroms vicroms deleted the pr/fix-wrong-version-hashes branch September 23, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants