Skip to content

Add a test for vite#172

Merged
DanielRosenwasser merged 2 commits intomainfrom
add-test-vite
May 5, 2022
Merged

Add a test for vite#172
DanielRosenwasser merged 2 commits intomainfrom
add-test-vite

Conversation

@rbuckton
Copy link
Copy Markdown
Contributor

This adds a test for vite.

Related to #143

@rbuckton rbuckton requested a review from weswigham February 10, 2022 20:26
@rbuckton
Copy link
Copy Markdown
Contributor Author

This also drops node@10 from the test matrix since its out of LTS support, and adds node@16 to the test matrix in its place.

@DanielRosenwasser
Copy link
Copy Markdown
Member

What triggers this running in CI?

@rbuckton
Copy link
Copy Markdown
Contributor Author

.github/workflows/CI.yml I would assume

Copy link
Copy Markdown
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here

@DanielRosenwasser DanielRosenwasser merged commit 5bfaf87 into main May 5, 2022
@DanielRosenwasser DanielRosenwasser deleted the add-test-vite branch May 5, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants