Repository navigation
Fix search compatibility bugs and Linux RSS test - #187
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The compatibility fixes are consistent across engines and backends with comprehensive regression coverage.
0 open findings
What changed in this PR
Improves ripgrep compatibility across pattern parsing, case handling, boundaries, multiline output, and RSS testing.
Changes:
- Preserves pattern-file semantics and correctly scopes smart case and inline flags.
- Fixes
-w/-xprecedence and adjacent multiline match reporting. - Expands cross-backend regression coverage and updates documentation.
| File | Description |
|---|---|
tgrep-cli/src/search.rs |
Snapshots patterns and fixes smart-case resolution. |
tgrep-cli/src/matching.rs |
Corrects boundaries, pattern scoping, and multiline spans. |
tgrep-cli/src/main.rs |
Implements ordered -w/-x overrides. |
tgrep-cli/src/mem.rs |
Removes invalid RSS ordering assertion. |
tgrep-cli/tests/ripgrep_compat.rs |
Adds cross-backend compatibility tests. |
tgrep-cli/Cargo.toml |
Adds required regex parser dependency and minimum version. |
Cargo.lock |
Records the direct dependency. |
README.md |
Documents corrected search semantics. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 9, 2026
-U --count-matches counts one cross-line match once per covered line and disagrees with --stats
#188
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-w, with equivalent lookarounds for the backtracking engine, and honor the last-w/-xflag across subcommands.Issues addressed
Fixes #181
Fixes #182
Fixes #183
Fixes #184
Fixes #185
Fixes #186