Repository navigation
Commit 3204323
Prune whitelisted hidden paths on unchanged verification
This PR keeps the raw hidden status of whitelisted files beside the
published visibility, so that a no-op notification for a whitelisted
dot-file is dropped. A verification that found the publication current
refreshed the evidence but kept that set as published.
On Windows, a file can lose both its hidden attribute and the whitelist
that admitted it without a change to its visibility or its file
version, which has no change time. If neither change was notified,
verification found nothing to publish and kept the stale entry. The
notification for setting the attribute again then looked unchanged and
was dropped, so the file stayed visible to queries without --hidden
until a later pass or verification. v1.2.6 invalidated in that case.
Elsewhere the raw hidden status depends only on the name, so changing
it is a rename, which verification sees as a membership change.
Unchanged verification now keeps only the entries that its own walk
still reports as hidden and whitelisted. It prunes the set rather than
replacing it, as it does the excluded records, because retained view
memory is charged for the published set. A whitelisted file hidden
since the last publication therefore has no entry and keeps
invalidating until a pass publishes.
Tests:
- unchanged_verification_prunes_whitelisted_entries_its_walk_no_longer_reports
(Windows) removes a file's hidden attribute and its info/exclude
whitelist without a notification, verifies, sets the attribute again
and expects HiddenChanged.
- unchanged_file_drops_whitelisted_hidden_files now also checks that
an unchanged verification keeps the entries its walk still reports.
Co-authored-by: Copilot App <[email protected]>1 parent b9da528 commit 3204323
3 files changed
Lines changed: 102 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1595 | 1595 | | |
1596 | 1596 | | |
1597 | 1597 | | |
1598 | | - | |
1599 | | - | |
1600 | | - | |
1601 | | - | |
1602 | | - | |
1603 | | - | |
| 1598 | + | |
| 1599 | + | |
| 1600 | + | |
| 1601 | + | |
| 1602 | + | |
| 1603 | + | |
1604 | 1604 | | |
1605 | 1605 | | |
1606 | | - | |
| 1606 | + | |
| 1607 | + | |
| 1608 | + | |
| 1609 | + | |
| 1610 | + | |
| 1611 | + | |
| 1612 | + | |
| 1613 | + | |
| 1614 | + | |
| 1615 | + | |
1607 | 1616 | | |
1608 | 1617 | | |
1609 | 1618 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1193 | 1193 | | |
1194 | 1194 | | |
1195 | 1195 | | |
1196 | | - | |
1197 | | - | |
1198 | | - | |
1199 | | - | |
1200 | | - | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
1201 | 1210 | | |
1202 | 1211 | | |
1203 | 1212 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1592 | 1592 | | |
1593 | 1593 | | |
1594 | 1594 | | |
| 1595 | + | |
| 1596 | + | |
| 1597 | + | |
| 1598 | + | |
| 1599 | + | |
| 1600 | + | |
| 1601 | + | |
| 1602 | + | |
1595 | 1603 | | |
1596 | | - | |
| 1604 | + | |
1597 | 1605 | | |
1598 | 1606 | | |
1599 | | - | |
1600 | | - | |
1601 | | - | |
1602 | | - | |
| 1607 | + | |
1603 | 1608 | | |
1604 | 1609 | | |
1605 | 1610 | | |
| |||
1621 | 1626 | | |
1622 | 1627 | | |
1623 | 1628 | | |
| 1629 | + | |
| 1630 | + | |
| 1631 | + | |
| 1632 | + | |
| 1633 | + | |
| 1634 | + | |
| 1635 | + | |
| 1636 | + | |
1624 | 1637 | | |
1625 | 1638 | | |
1626 | 1639 | | |
| |||
1646 | 1659 | | |
1647 | 1660 | | |
1648 | 1661 | | |
| 1662 | + | |
| 1663 | + | |
| 1664 | + | |
| 1665 | + | |
| 1666 | + | |
| 1667 | + | |
| 1668 | + | |
| 1669 | + | |
| 1670 | + | |
| 1671 | + | |
| 1672 | + | |
| 1673 | + | |
| 1674 | + | |
| 1675 | + | |
| 1676 | + | |
| 1677 | + | |
| 1678 | + | |
| 1679 | + | |
| 1680 | + | |
| 1681 | + | |
| 1682 | + | |
| 1683 | + | |
| 1684 | + | |
| 1685 | + | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
| 1714 | + | |
| 1715 | + | |
1649 | 1716 | | |
1650 | 1717 | | |
1651 | 1718 | | |
| |||
0 commit comments