Added basic WinUI3 support.#782
Conversation
- Fixed obsolution warnings on nuspec files. - Fixed a small typo on a resource.
|
@azchohfi, thank you for the contribution. This looks OK; after testing and getting more feedback from the team, I'll merge. |
|
This is great! The reason for the failing TestFx.CI.Real is that the build machine is still on old build configurations. It needs VS2019, for net5, and this is still running on a VS2017 machine. |
|
The VM pool we're using does not have the required SDK installed. It's getting fixed. |
|
Any updates on this? |
# Conflicts: # src/Package/MSTest.TestAdapter.Dotnet.nuspec
|
The infra team is still working on that. Hopefully, they'll push the new images this week, and we can merge this. |
|
Build seems to be passing now. |
|
@azchohfi, the failing one is our internal pipeline that generates the signed builds. I'll check back with the infra team and try to resolve this asap. |
|
I'll update this to use ProjectReunion 0.5.0-prerelease. |
Haplois
left a comment
Haplois
left a comment
There was a problem hiding this comment.
Package generation failed, with the fixed pipeline as well. Could you check it?
~\scripts\build\TestFx.Loc.targets(73,5): error MSB3073: The command "xcopy /Y /I /S /E ..\..\..\packages\MSTest.Internal.TestFx.Localized.Documentation.1.0.0-build-20170420-1\contentFiles\any\any\Extensions\WinUI ..\..\..\artifacts\Release\Extension.WinUI\" exited with code 4. [~\src\TestFramework\Extension.WinUI\Extension.WinUI.csproj]
Co-authored-by: Medeni Baykal <[email protected]>
|
@Haplois The issue seems to be that MSTest.Internal.TestFx.Localized.Documentation, version 1.0.0-build-20170420-1 doesn't have any WinUI related xml files, which makes sense since this PR didn't update that package. Could you point me to where this should be updated? |
|
@azchohfi, there is a chicken and egg problem :) This repository generates that package; we need this merged to get those files. I'll fix that tomorrow and hopefully merge it. |
| /// Gets or sets the <see cref="Microsoft.System.DispatcherQueue"/> that should be used to invoke the UITestMethodAttribute. | ||
| /// If none is provided, it will try to use the Microsoft.UI.Xaml.Window.Current.DispatcherQueue, which only works on UWP. | ||
| /// </summary> | ||
| public static Microsoft.System.DispatcherQueue DispatcherQueue { get; set; } |
There was a problem hiding this comment.
hmm, this would cause issues if the tests are run in parallel, wouldn't it?
There was a problem hiding this comment.
I can't see why it could, given that you provide one. The same concept was/is used in UWP, and it works fine (UWP used a static property to get the CoreDispatcher). Preferably, this should be set only once, and only if needed.
|
Added |
Haplois
force-pushed
the
winui3
branch
3 times, most recently
from
a0ba65f to
ad520d8
Compare
Haplois
left a comment
Haplois
left a comment
There was a problem hiding this comment.
I fixed the issues with the build, we need to add some acceptance tests, but it looks ok.
Scottj1s
left a comment
Scottj1s
left a comment
There was a problem hiding this comment.
This is great, and much needed - thx!
4 participants
No description provided.