Cleanup TestApplication#6728
Merged
Merged
Conversation
Youssef1313
force-pushed
the
dev/ygerges/cleanup-testapp
branch
from
b8115e9 to
ac1825f
Compare
engyebrahim
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITestApplicationand not the concreteTestApplication. We dispose via the syncDispose(the interface doesn't actually implement IAsyncDisposable). While binary breaking and should have been figured out before we ship 2.0.0, I think it only affects the case where users castITestApplicationtoTestApplicationand callsDisposeAsyncwhich is extremely unlikely.CreateServerModeBuilderAsyncis also mostly an unused public API. We don't use it in our generated entrypoint and I don't think there are any usages calling it. I went with obsoletion though instead of breaking. I would personally be fine taking a binary break here though. It's expected to affect literally zero users.