Skip to content

[rel/4.0]: Unify TestSessionContext#6344

Closed
Youssef1313 wants to merge 2 commits intorel/4.0from
dev/ygerges/unify-testsessioncontext
Closed

[rel/4.0]: Unify TestSessionContext#6344
Youssef1313 wants to merge 2 commits intorel/4.0from
dev/ygerges/unify-testsessioncontext

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

Related to #5762

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/unify-testsessioncontext branch from bdb17b5 to 9e6b680 Compare August 11, 2025 19:48

namespace Microsoft.Testing.Platform.Services;

internal sealed class TestSessionContext(CancellationToken cancellationToken) : ITestSessionContext
Copy link
Copy Markdown
Member Author

@Youssef1313 Youssef1313 Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: Previously this was internal (in Services namespace), and another public TestSessionContext was in TestHost namespace.

I'm not really sure if it makes more sense to expose in Services namespace or TestHost namespace.

The notable public APIs with TestSessionContext in signature is TestExecutionRequest.Session (well, the property name isn't super good IMO but that's a different discussion). The TestExecutionRequest is kinda testhost-specific I think.

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/unify-testsessioncontext branch 2 times, most recently from 0de95f5 to 3d5fce7 Compare August 12, 2025 03:51
@Youssef1313 Youssef1313 force-pushed the dev/ygerges/unify-testsessioncontext branch from 3d5fce7 to a5515c3 Compare August 12, 2025 03:58
@Youssef1313 Youssef1313 mentioned this pull request Aug 15, 2025
20 tasks
@Youssef1313 Youssef1313 deleted the dev/ygerges/unify-testsessioncontext branch September 25, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant