ConditionBaseAttribute.ShouldRun -> IsConditionMet#6117
Merged
Evangelink merged 2 commits intorel/4.0from Jul 21, 2025
Merged
Conversation
Youssef1313
force-pushed
the
dev/ygerges/conditionbase
branch
from
a85671f to
884d516
Compare
Evangelink
reviewed
Jul 21, 2025
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
As discussed offline, it would probably be a good opportunity to transform the property into an async method so we avoid the need for a breaking change like we did for test method.
Member
Author
|
@Evangelink There are some calls under |
Evangelink
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1285
Closes #6086