Change TestContext.Properties to use generic IDictionary#5828
Merged
Evangelink merged 2 commits intodev/v4from Jun 20, 2025
Merged
Change TestContext.Properties to use generic IDictionary#5828Evangelink merged 2 commits intodev/v4from
Evangelink merged 2 commits intodev/v4from
Conversation
Youssef1313
changed the title
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Youssef1313
force-pushed
the
dev/ygerges/testcontext
branch
2 times, most recently
from
abac336 to
dc21d28
Compare
Youssef1313
force-pushed
the
dev/ygerges/testcontext
branch
from
dc21d28 to
f29ebd9
Compare
Evangelink
reviewed
Jun 19, 2025
Comment on lines
+71
to
+73
| Verify(testContext.Context.Properties.ContainsKey(properties.ToArray()[0].Key)); | ||
|
|
||
| Verify(testContext.Context.Properties.Contains(properties.ToArray()[0]!)); |
Member
There was a problem hiding this comment.
Can we simplify the ToArray()?
Member
Author
There was a problem hiding this comment.
I did a simplification that came to mind. Is it better?
Evangelink
approved these changes
Jun 20, 2025
microsoft-github-policy-service
bot
added
the
Area: MSTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1377
Related to #1285