Update TestContext.Properties return type to IDictionary<string, object?>#1481
Merged
Evangelink merged 10 commits intomicrosoft:mainfrom Dec 19, 2022
Merged
Conversation
engyebrahim
changed the title
Evangelink
changed the title
Evangelink
reviewed
Dec 19, 2022
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
You can simplify furthermore the GetProperty method of TestContext.
@MarcoRossignoli Do you think we should go with IDictionary over Dictionary?
src/Adapter/MSTestAdapter.PlatformServices/Services/TestContextImplementation.cs
Outdated
Show resolved
Hide resolved
Contributor
I would use always abstraction if possible so yes. |
engyebrahim
changed the title
Evangelink
reviewed
Dec 19, 2022
Evangelink
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #1377