When the window is summoned and is already active, minimize it. by zadjii-msft · Pull Request #9963 · microsoft/terminal

zadjii-msft · 2021-04-26T21:16:20Z

This adds a toggleVisibility parameter to globalSummon.

When true (default): when you press the global summon keybinding, and the window is currently the foreground window, we'll minimize the window.
When false, we'll just do nothing.

References

Original thread: Feature request: hot key drop down ala quake/guake/tilda #653
Spec: Spec for Quake Mode #9274
megathread: [MEGATHREAD] Quake Mode & Global Summon #8888

PR Checklist

Checks a box in [MEGATHREAD] Quake Mode & Global Summon #8888
closes https://github.com/microsoft/terminal/projects/5#card-59030814
I work here
No tests for this one.
yes yes eventually I'll come back on the docs

Detailed Description of the Pull Request / Additional comments

I've got nothing extra to add here. This one's pretty simple. I'm only targeting #9954 since that one laid so much foundation to build on, with the SummonBehavior

Validation Steps Performed

Played with this for a while, and it's amazing.

…ompile a String[]

…then back!

…!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

…safely tear it down. It _seems_ like it.

….dll

…galactic-empire

…ndow should be. It just always says 0 for now, but in the future it could actually give us useful info.

…Current-desktop # Conflicts: # src/cascadia/TerminalApp/AppLogic.idl # src/cascadia/WindowsTerminal/AppHost.cpp # src/cascadia/WindowsTerminal/AppHost.h

…Current-desktop

…E-MODE

…Current-desktop

DHowett · 2021-04-28T16:48:05Z

tfw this pr has 2 signoffs but #9954 before it has none, and #9854 before that one only has one

small atomic PRs are nice and easy 😉

…E-MODE

…Current-desktop

…/quake-toggleVisibility

(cherry picked from commit d3297bdc8740410e9c73c1cc15d5aa9fb5d2f109)

ghost · 2021-04-28T22:27:51Z

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

…com/microsoft/terminal into dev/migrie/f/quake-toggleVisibility

DHowett · 2021-04-28T23:26:43Z

I'm fixing the x86 leg break

DHowett · 2021-04-28T23:35:24Z

src/cascadia/UnitTests_Remoting/RemotingTests.cpp

            return E_FAIL;
        }
-        HRESULT IsWindowOnCurrentVirtualDesktop(HWND topLevelWindow, BOOL* onCurrentDesktop)
+        IFACEMETHOD(IsWindowOnCurrentVirtualDesktop)


yes clang-format did this no i don't like it but oh well

github-actions · 2021-04-28T23:36:51Z

Misspellings found, please review:

IFACEMETHOD

To accept these changes, run the following commands from this repository on this branch

pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect/alphabet.txt
.github/actions/spelling/expect/expect.txt
.github/actions/spelling/expect/web.txt"');
@ARGV=@expect_files;
my @stale=qw('"aef aspnet boostorg BSODs Cac COINIT dahall DEFCON developercommunity fde fea fmtlib hotkeys HPCON isocpp llvm mintty msvcrtd Nc NVDA pinam QOL remoting UNINIT Unk unte vcrt what3words xamarin "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect/65b22b9abba26fa94150505cee4444dcb4e42182.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling/expect";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"cac coinit hpcon IFACEMETHOD LLVM MSVCRTD nc Remoting uninit unk "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. You can copy the contents of each perl command excluding the outer ' marks and dropping any '"/"' quotation mark pairs into a file and then run perl file.pl from the root of the repository to run the code. Alternatively, you can manually insert the items...

If the listed items are:

... misspelled, then please correct them instead of using the command.
... names, please add them to .github/actions/spelling/dictionary/names.txt.
... APIs, you can add them to a file in .github/actions/spelling/dictionary/.
... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

🗜️ If you see a bunch of garbage and it relates to a binary-ish string, please add a file path to the .github/actions/spelling/excludes.txt file instead of just accepting the garbage.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

ghost · 2021-05-25T19:11:12Z

🎉Windows Terminal Preview v1.9.1445.0 has been released which incorporates this pull request.:tada:

Handy links:

zadjii-msft added 30 commits December 16, 2020 07:59

Get all the projects created and hooked up to the sln

3bef7bb

Yank all the M/P files, this builds?!

1f52d35

Shockingly, this works, it works elevated, and it works unpackaged

5a9cdc8

This won't work, but I'm committing this becaus I finally got it to c…

36539cf

…ompile a String[]

whoop, we pass the commandline from the peasant, to the monarch, and …

27ace16

…then back!

HOLY SHIT I GOT THE COMANDLINE TO EXECUTE IN THE CURRENT WINDOW!!!!!!…

9a41647

…!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

add a note to future me

5cabcfb

This works as a unittest, but not a local test. That's batty

03bfc6e

this macro makes me feel dirty

590b9ff

LocalTests_Remoting -> UnitTests_Remoting

0579b24

finish renaming this test

a3faed6

Clean up a lot for review

9c6eac4

cleanup Peasant for review

0103331

Final cleanup for review

b4fe1bf

_final_ final cleanup for review

d08e65c

pr nits

e101efd

This seems to work to create a thread listening for the monarch, and …

e1402d8

…safely tear it down. It _seems_ like it.

it's hard to believe he's gone / were it so easy

f978a9c

Oh yea actually remove the thing

5939636

last commit before the holidays

c088895

Merge remote-tracking branch 'origin/main' into dev/migrie/f/remoting…

fa2df47

….dll

Enable audit mode

0f5c24f

nits

921d915

Merge branch 'dev/migrie/f/remoting.dll' into dev/migrie/f/the-first-…

00184e7

…galactic-empire

Ask the TerminalApp to parse the commandline, and tell us what the wi…

658db6b

…ndow should be. It just always says 0 for now, but in the future it could actually give us useful info.

Holy bajesus, this works like a charm

977db46

Add a note about commiting suicide

bcbef34

notes, comments, cleanup

813dbc6

activate windows

0f0df5e

add some tracelogging

9fc2f0e

zadjii-msft added 5 commits April 28, 2021 06:09

Merge remote-tracking branch 'origin/main' into dev/migrie/f/quake-to…

84c1bd9

…Current-desktop # Conflicts: # src/cascadia/TerminalApp/AppLogic.idl # src/cascadia/WindowsTerminal/AppHost.cpp # src/cascadia/WindowsTerminal/AppHost.h

BODGY fix for newer builds

24bfbe6

Merge remote-tracking branch 'origin/main' into dev/migrie/f/quake-to…

4c2e6d2

…Current-desktop

Merge remote-tracking branch 'origin/main' into dev/migrie/f/653-QUAK…

aec2561

…E-MODE

Merge branch 'dev/migrie/f/653-QUAKE-MODE' into dev/migrie/f/quake-to…

22036c2

…Current-desktop

zadjii-msft mentioned this pull request Apr 28, 2021

Add property to control dropdown speed of global summon #9977

Merged

3 tasks

zadjii-msft added 5 commits April 28, 2021 15:25

Merge remote-tracking branch 'origin/main' into dev/migrie/f/653-QUAK…

5940f05

…E-MODE

Address Dustin's PR comments

06cb41b

Merge branch 'dev/migrie/f/653-QUAKE-MODE' into dev/migrie/f/quake-to…

783be75

…Current-desktop

pr nits

6c424f7

Merge branch 'dev/migrie/f/quake-toCurrent-desktop' into dev/migrie/f…

387d675

…/quake-toggleVisibility

DHowett force-pushed the dev/migrie/f/quake-toCurrent-desktop branch from 6c424f7 to fe51444 Compare April 28, 2021 22:19

DHowett force-pushed the dev/migrie/f/quake-toggleVisibility branch from 387d675 to 04752e5 Compare April 28, 2021 22:22

Base automatically changed from dev/migrie/f/quake-toCurrent-desktop to main April 28, 2021 22:25

Squash merge of Toggle Visibility

1032dbb

(cherry picked from commit d3297bdc8740410e9c73c1cc15d5aa9fb5d2f109)

DHowett force-pushed the dev/migrie/f/quake-toggleVisibility branch from 04752e5 to 1032dbb Compare April 28, 2021 22:26

DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 28, 2021

zadjii-msft added 2 commits April 28, 2021 17:56

Merge branch 'dev/migrie/f/quake-toggleVisibility' of https://github.…

242f3e2

…com/microsoft/terminal into dev/migrie/f/quake-toggleVisibility

that's what I get for making changes w/o building

3e3cb1d

Fix calling convention for COM impls

53e3fe9

DHowett reviewed Apr 28, 2021

View reviewed changes

surprised we didn't already have one of these..

fffda9f

DHowett removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 28, 2021

DHowett merged commit 30d2d2c into main Apr 28, 2021

DHowett deleted the dev/migrie/f/quake-toggleVisibility branch April 28, 2021 23:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When the window is summoned and is already active, minimize it.#9963

When the window is summoned and is already active, minimize it.#9963
DHowett merged 109 commits intomainfrom
dev/migrie/f/quake-toggleVisibility

zadjii-msft commented Apr 26, 2021 •

edited by DHowett

Loading

Uh oh!

DHowett commented Apr 28, 2021

Uh oh!

ghost commented Apr 28, 2021

Uh oh!

DHowett commented Apr 28, 2021

Uh oh!

DHowett Apr 28, 2021

Uh oh!

github-actions bot commented Apr 28, 2021

Uh oh!

ghost commented May 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

zadjii-msft commented Apr 26, 2021 • edited by DHowett Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Uh oh!

DHowett commented Apr 28, 2021

Uh oh!

ghost commented Apr 28, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

DHowett commented Apr 28, 2021

Uh oh!

DHowett Apr 28, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 28, 2021

Misspellings found, please review:

Uh oh!

ghost commented May 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zadjii-msft commented Apr 26, 2021 •

edited by DHowett

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.