Eat all tab keypresses no matter what.#985
Merged
zadjii-msft merged 1 commit intomasterfrom May 24, 2019
Merged
Conversation
Contributor
|
Do we need to evaluate whether our key handler is in the right place? I'm worried about this and the |
Member
Author
|
The alt+bell seems to be totally out of our control. I tried eating all the alt's manually, and that doesn't seem to change anything about that path. Is there somewhere else you're thinking about for moving our key handling to? I don't know what other place would make sense. |
Member
|
Only concern I would note is possible accessibility implications. As long as there's a follow-up to address the focus issue though it's probably fine? |
Contributor
|
I know for Narrator, there is a different way to navigate through elements than tab. |
adiviness
approved these changes
May 24, 2019
miniksa
approved these changes
May 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fix #744, by making sure the TermControl always handles Tab keypresses. This will break keyboard navigation with tab, but considering that the shell almost always wants tab as a character, this makes more sense. We should probably introduce another keybinding to manually get the focus out of the control, but that can be a follow-up.
PR Checklist