Merged
Conversation
ghost
added
Area-CodeHealth
miniksa
approved these changes
Apr 14, 2021
carlos-zamora
approved these changes
Apr 14, 2021
DHowett
approved these changes
Apr 14, 2021
Member
|
@msftbot merge this in 1 minute |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit 
Member
Author
|
@miniksa weren't we supposed to be getting emails when nightly helix builds failed? Wonder why we didn't get any for this particular set |
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Apr 17, 2021
## Summary of the Pull Request Clearly, I didn't run these tests on my last commit where I made the toasts lazy-load. ## References * broken in in microsoft#9662 * ## PR Checklist * [x] Closes microsoft#9769 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments For whatever reason, these tests are unhappy running back to back, but are just fine running isolated.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Clearly, I didn't run these tests on my last commit where I made the toasts lazy-load.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
For whatever reason, these tests are unhappy running back to back, but are just fine running isolated.