Skip to content

Add a success dialog to window renaming#9808

Merged
5 commits merged intomainfrom
dev/migrie/b/9804-rename-confirmation
Apr 22, 2021
Merged

Add a success dialog to window renaming#9808
5 commits merged intomainfrom
dev/migrie/b/9804-rename-confirmation

Conversation

@zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Apr 14, 2021 •
edited by DHowett
Loading

I added a RenameSucceededText property to the TerminalPage which returns the
formatted message Successfully renamed window to "{WindowNameForDisplay()}"

This doesn't pop the dialog when you wt -w foo for the first time. Only
subsequent renames.

References

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Apr 14, 2021
@ghost ghost added the Area-Settings Issues related to settings and customizability, for console or terminal label Apr 14, 2021
miniksa
miniksa reviewed Apr 14, 2021
View reviewed changes
carlos-zamora
carlos-zamora reviewed Apr 14, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. I just don't like the content of the confirmation toast; feels redundant, but idk how to fix it. Once that gets figured out, I'll approve.

carlos-zamora
carlos-zamora requested changes Apr 21, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things. If possible, update the gif in the OP too please.

Also, are we gonna service this?

src/cascadia/TerminalApp/Resources/en-US/Resources.resw
@@ -1,17 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Member

@carlos-zamora carlos-zamora Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: undo changes to this file

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 21, 2021
@DHowett
Copy link
Member

DHowett commented Apr 22, 2021

moved from body window-rename-success-000

@DHowett
Copy link
Member

DHowett commented Apr 22, 2021

@carlos-zamora I addressed your nits

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 22, 2021
@ghost
Copy link

ghost commented Apr 22, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit aa54de1 into main Apr 22, 2021
@ghost ghost deleted the dev/migrie/b/9804-rename-confirmation branch April 22, 2021 21:16
DHowett pushed a commit that referenced this pull request May 14, 2021
@zadjii-msft @DHowett
Add a success dialog to window renaming (#9808)
ed3feef 
I added a `RenameSucceededText` property to the `TerminalPage` which returns the
formatted message `Successfully renamed window to "{WindowNameForDisplay()}"`

This _doesn't_ pop the dialog when you `wt -w foo` for the first time. Only
_subsequent_ renames.

## References
* Added in #9662
* Closes #9804

(cherry picked from commit aa54de1)
@ghost
Copy link

ghost commented May 25, 2021

🎉Windows Terminal v1.8.1444.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request May 25, 2021
Closed
@ghost
Copy link

ghost commented May 25, 2021

🎉Windows Terminal Preview v1.9.1445.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa miniksa approved these changes

+1 more reviewer

@cinnamon-msft cinnamon-msft cinnamon-msft left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@carlos-zamora carlos-zamora

@cinnamon-msft cinnamon-msft

Labels

Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Renaming the window should display confirmation

5 participants

@zadjii-msft @DHowett @carlos-zamora @miniksa @cinnamon-msft