Propagate the hosting HWND to the new IFileDialogs#9789
Merged
1 commit merged intomainfrom Apr 12, 2021
Merged
Conversation
This is required to maintain the modality of the dialogs, which we lost when we moved from Pickers to IFileDialog. The HWND hosting Window API we dreamed up is incompatible with IModalDialog, because IModalDialog requires the HWND immediately upon `Show`. We're smuggling it in a uint64, as is tradition.
Member
Author
|
@msftbot merge this in 2 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
zadjii-msft
approved these changes
Apr 12, 2021
miniksa
approved these changes
Apr 12, 2021
ghost
merged commit
DHowett
added a commit
that referenced
this pull request
Apr 12, 2021
This is required to maintain the modality of the dialogs, which we lost when we moved from Pickers to IFileDialog. The HWND hosting Window API we dreamed up is incompatible with IModalDialog, because IModalDialog requires the HWND immediately upon `Show`. We're smuggling it in a uint64, as is tradition. zadjii-msft noticed this in #9760. (cherry picked from commit 8f79f7c)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to maintain the modality of the dialogs, which we lost
when we moved from Pickers to IFileDialog. The HWND hosting Window API
we dreamed up is incompatible with IModalDialog, because IModalDialog
requires the HWND immediately upon
Show. We're smuggling it in auint64, as is tradition.
zadjii-msft noticed this in #9760.