Match the RequestedTheme of our TeachingTips to the set theme#9732
Merged
2 commits merged intomainfrom Apr 7, 2021
Merged
Conversation
ghost
added
Area-UserInterface
DHowett
reviewed
Apr 6, 2021
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
I hate that this is necessary, but I appreciate you figuringit out
DHowett
approved these changes
Apr 6, 2021
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
I hate that this is necessary, but I appreciate you figuringit out
Member
|
@msftbot merge this in 7 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Member
|
Oh, it was this one with the conflict |
carlos-zamora
approved these changes
Apr 7, 2021
ghost
merged commit 
2 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Make sure that the window renamer and other toasts follow the requested app theme. We accomplish this by doing something similar to what we do with ContentDialogs. Since TeachingTips aren't in the same XAML root, we have to traverse the entire tree upwards setting RequestedTheme. If we don't, then we'll update the background color of the TeachingTip, but not the text inside it.
References
PR Checklist
Validation Steps Performed
Tested with system theme light & dark, and
themeset to `light, dark, and unset, and verified that they worked as expected.