Manually handle Enter and Escape in the Window Renamer#9730
Merged
1 commit merged intomainfrom Apr 6, 2021
Merged
Conversation
ghost
added
Area-UserInterface
carlos-zamora
approved these changes
Apr 6, 2021
Comment on lines
+2695
to
+2705
| if (e.OriginalKey() == Windows::System::VirtualKey::Enter) | ||
| { | ||
| // User is done making changes, close the rename box | ||
| _WindowRenamerActionClick(sender, nullptr); | ||
| } | ||
| else if (e.OriginalKey() == Windows::System::VirtualKey::Escape) | ||
| { | ||
| // User wants to discard the changes they made | ||
| WindowRenamerTextBox().Text(WindowName()); | ||
| WindowRenamer().IsOpen(false); | ||
| } |
Member
There was a problem hiding this comment.
Don't we need an e.Handled(true); for each of these?
Member
Author
There was a problem hiding this comment.
meh maybe? Doesn't seem like these bubble up to anyone else but I can roll it
DHowett
approved these changes
Apr 6, 2021
Member
|
@msftbot merge this in 1 minute |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
In exactly the same fashion as the tab renamer, handle Enter for committing the rename, and Escape for dismissing the rename.
References
PR Checklist
Validation Steps Performed
Played with it - this feels good.