[Settings UI] Represent Cursor Height as a slider by eugenesmlv · Pull Request #9386 · microsoft/terminal

eugenesmlv · 2021-03-05T09:21:13Z

Change the vintage cursor height number box to a slider.

References

Related: #9370

PR Checklist

Closes Represent Cursor Height as a slider #9377
zadjii-msft edit: Now this one closes Allow "vintage" cursor to have values lower than 25 #9175
CLA signed. If not, go over here and sign the CLA
Schema updated.
Documentation updated here: Update cursorHeight minimum value MicrosoftDocs/terminal#278

Detailed Description of the Pull Request / Additional comments

It seems like the cursor height couldn't be lower than 25 percent regardless of the given value, so I've changed the MinCursorHeightPercent in CustomTextRenderer header file.

Validation Steps Performed

Manual validation

zadjii-msft

This looks great to me!

zadjii-msft · 2021-03-05T11:33:12Z

@msftbot make sure @carlos-zamora signs off on this

ghost · 2021-03-05T11:33:18Z

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

I'll only merge this pull request if it's approved by @carlos-zamora

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

carlos-zamora

The UI looks perfect! Nice work! Only thing I'm worried about is changing the min value to be less than 25. So I tagged some team members with more experience there.

Thanks for updating the schema. I bet we specifically mention a minimum of 25 in the docs too. Mind making a PR over there and updating that too (then linking it here)?

Other than that, this is perfect! Thank you so much!

carlos-zamora · 2021-03-05T18:23:26Z

src/renderer/dx/CustomTextRenderer.h

    };

-    constexpr const ULONG MinCursorHeightPercent = 25;
+    constexpr const ULONG MinCursorHeightPercent = 1;


(oops, the comment didn't save)

Only thing I'm concerned about is some kind of side effect here.

@miniksa @DHowett Any ideas why this was set to 25 before? Will this horrifically explode in some way?

So if we set the value to something less than 25, the cursor height updates accordingly right? We're not clamping it to 25 anymore, so setting it to less than 25 actually get smaller?

I bet we specifically mention a minimum of 25 in the docs too. Mind making a PR over there and updating that too (then linking it here)?

Sure! But I could not found any mention of the minimum cursor height value in docs. Do you mean documentation in the doc folder or there is a separate repo for that?

The cursor becomes smaller on values less than 25, but if I set the value to less than 6, the cursor disappears.

I probably found why the minimum value was set to 25:

terminal/src/buffer/out/cursor.h

Lines 28 to 30 in ae550e0

// the following values are used to create the textmode cursor.

static constexpr unsigned int CURSOR_SMALL_SIZE = 25; // large enough to be one pixel on a six pixel font

Sure! But I could not found any mention of the minimum cursor height value in docs. Do you mean documentation in the doc folder or there is a separate repo for that?

Ah, yes. My bad. I'm thinking about this section of the docs site, in particular. That's generated by our docs repo here.

The cursor becomes smaller on values less than 25, but if I set the value to less than 6, the cursor disappears.

I probably found why the minimum value was set to 25:

Hmm. That "large enough to be one pixel on a six pixel font" comment seems like a reason keep the minimum size to 25 imo. I think we should revert the changes to the schema and renderer, and change the minimum value on the slider to 25 then.

But I definitely want Michael or Dustin to check on this one to be safe (along with what you found in the GdiEngine).

Sorry for blocking on such an annoying little thing!

So, if we revert the minimum value back to 25 shouldn't we also change the slider to number box? The slider looks prettier, but one with minimum value of 25 seems a little bit odd, in my opinion.

eugenesmlv · 2021-03-05T21:43:19Z

I've changed the minimum cursor height value in CustomTextRenderer.h, but there is another one in gdirenderer.hpp which is used in GdiEngine::PaintCursor method. Should we also change that?

terminal/src/renderer/gdi/gdirenderer.hpp

Lines 153 to 154 in 4c53c59

    
           static const ULONG s_ulMinCursorHeightPercent = 25; 
        
           static const ULONG s_ulMaxCursorHeightPercent = 100;

terminal/src/renderer/gdi/paint.cpp

Lines 588 to 590 in 4c53c59

    
           ULONG ulHeight = options.ulCursorHeightPercent; 
        
           ulHeight = std::max(ulHeight, s_ulMinCursorHeightPercent); // No smaller than 25% 
        
           ulHeight = std::min(ulHeight, s_ulMaxCursorHeightPercent); // No larger than 100%

zadjii-msft · 2021-03-08T22:44:24Z

@carlos-zamora or @miniksa: This is the one we talked about in team sync today - I'll follow up with the clamp-to-1px thing we mentioned

miniksa · 2021-03-08T22:46:14Z

I've changed the minimum cursor height value in CustomTextRenderer.h, but there is another one in gdirenderer.hpp which is used in GdiEngine::PaintCursor method. Should we also change that?

terminal/src/renderer/gdi/gdirenderer.hpp

Lines 153 to 154 in 4c53c59

static const ULONG s_ulMinCursorHeightPercent = 25;

static const ULONG s_ulMaxCursorHeightPercent = 100;

terminal/src/renderer/gdi/paint.cpp

Lines 588 to 590 in 4c53c59

ULONG ulHeight = options.ulCursorHeightPercent;

ulHeight = std::max(ulHeight, s_ulMinCursorHeightPercent); // No smaller than 25%

ulHeight = std::min(ulHeight, s_ulMaxCursorHeightPercent); // No larger than 100%

Please don't update the GdiEngine for this. Update only the DxEngine one.

eugenesmlv · 2021-03-09T15:58:18Z

src/renderer/dx/CustomTextRenderer.cpp

        // Enforce min/max cursor height
        ULONG ulHeight = std::clamp(options.ulCursorHeightPercent, MinCursorHeightPercent, MaxCursorHeightPercent);
        ulHeight = (glyphSize.height<ULONG>() * ulHeight) / 100;
+        ulHeight = std::max(ulHeight, MinCursorHeightPixels); // No smaller than 1px


@carlos-zamora, @zadjii-msft what if we restrict the minimum cursor height value to 1px? On values less than 25 the cursor is getting smaller until it reaches the 1px height. If one decreases the value further, it won't change anything.

If you think it's ok, I'll also update the docs.

I'm ok with that. 😊

carlos-zamora

Thanks for doing this!

ghost · 2021-03-09T17:13:29Z

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Documentation update for microsoft/terminal#9386

eugenesmlv · 2021-03-09T20:36:54Z

Sorry for commenting in closed PR, but I don't think it worth creating a new issue.

Please don't update the GdiEngine for this. Update only the DxEngine one.

@miniksa could you please explain a little more about the GdiEngine and why one shouldn't update it along with the DxEngine? I've read the How are the Windows graphics/messaging stack assembled? doc's section (great explanation, by the way!) but still can't find an answer.

zadjii-msft · 2021-03-09T20:42:47Z

The GdiEngine is the one that's used for drawing the vintage console host (conhost.exe). The DxEngine is only used by the Terminal. He was just asking to make sure that this change was only scoped to the DxEngine, so that the vintage console host didn't change behavior. We can't change the console as easily as we can the Terminal ☺️

miniksa · 2021-03-09T20:48:27Z

Sorry for commenting in closed PR, but I don't think it worth creating a new issue.

Please don't update the GdiEngine for this. Update only the DxEngine one.

@miniksa could you please explain a little more about the GdiEngine and why one shouldn't update it along with the DxEngine? I've read the How are the Windows graphics/messaging stack assembled? section (great explanation, by the way!) but still can't find an answer.

Couple things:

The GdiEngine is only used for the conhost.exe/OpenConsole.exe product, also known as the inbox windows console, for its headed window implementation. The Windows Terminal product, by contrast, uses DxEngine instead. Given this PR is coming in from the perspective of the Terminal settings UI, I thought it appropriate to scope it to the Terminal rendering targets only.
Scoping to only Terminal, and not the inbox console, drops a lot of potential compatibility and OS interaction concerns off my mind. For instance, there could be some interaction I'm not foreseeing with the property sheet (console.dll) or the conhost settings processing that could cause a bug. It could be that someone out there is using a regkey with a size of 12% for their cursor implementation on a factory line, but because it always bottomed out graphically at 25% for the GDI renderer, it was never a problem. In a perfect world, our code base would have checked the 25% minimum in the propsheet, console settings code, and at the renderer, but it's highly possible and even probable that this is the only check.
Our long term goal is that no one will use the classic console window and by extension the GdiEngine anymore once Terminal can completely replace it. Or at least replace the graphical and interaction components as ConPTY will still need to be there no matter what. So I'd rather not spend effort on it and avoid potential unpredictable future bug investigations by just... not changing it if we don't NEED to.

eugenesmlv · 2021-03-09T20:50:12Z

Thanks! Now it became clear to me 😊

ghost · 2021-04-14T17:08:27Z

🎉Windows Terminal Preview v1.8.1032.0 has been released which incorporates this pull request.:tada:

Handy links:

Documentation update for microsoft/terminal#9386

@aloneguid

* command-line-arguments.md: Tag the Command Prompt code blocks For some reason they were tagged as bash, which broke highlighting in at least one of them. * fixed typo (#220) in line 98 it's `C:\\path\\to\\icon.png` while in line 115 it was `C:\\path\\to\\icon` so I've added the missing `.png` * Add note about escaping characters with backslash (#230) Originally filed by Andrewery https://github.com/MicrosoftDocs/terminal/pull/134/files * Add icon example and folder location (#231) From #135 * Add icon example and folder location As originally submitted by @aloneguid in #135 * Remove code brackets for readability * Add spacing * Fix default value by escaping characters (#232) Original submission: https://github.com/MicrosoftDocs/terminal/pull/134/files * Add info about the command palette (#180) * Add info about the command palette 1. Add info about the command palette. 2. Typo fixes (e.g. "quick-start guide" instead of "quickstart") 3. Style fix, e.g. we don't have a keyboard key whose full name is "alt+shift+plus". * revert description Co-authored-by: Matt Wojciakowski <[email protected]> * Add backslash escape note (#233) ...from PR #181 * Add a note about hiding dynamic profiles (#186) * Add a note about hiding dynamic profiles * Minor writing updates Co-authored-by: Matt Wojciakowski <[email protected]> * Clarify adding profile in ssh tutorial. Fixes #183 (#193) * Clarify adding profile in ssh tutorial. Fixes: #183 * Remove from docs link * Add guid command for powershell (#234) migrated from PR https://github.com/MicrosoftDocs/terminal/pull/199/files * Change "i.e." to "e.g." (#207) This seems to be the intended meaning: There are Linux distributions that are not Ubuntu, but Ubuntu is an example of a Linux distribution for which the behavior is the given. * Old Ubuntu: Use up-to-date version of golang (#216) Currently, the install recommends using an out-of-date version of golang, which in turn causes issues while installing powerline-go. * Add startingDirectory example (#237) * Add startingDirectory example * Format startingDirectory entry * remove icon file type Co-authored-by: Kayla Cinnamon <[email protected]> * Change icon description to example * Change false to true Co-authored-by: Kayla Cinnamon <[email protected]> * Remove unnecessary sentence Co-authored-by: Kayla Cinnamon <[email protected]> * Typo fixes Co-authored-by: Kayla Cinnamon <[email protected]> * link fix Co-authored-by: Kayla Cinnamon <[email protected]> * Capitalization fixes Co-authored-by: Kayla Cinnamon <[email protected]> * shortcut fixes Co-authored-by: Kayla Cinnamon <[email protected]> * page_title_updates_terminal (#243) * Add docs for `newWindow` action (#259) * refactor(powerline): update for oh-my-posh V3 (#263) * Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` (#123) Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` * Update powerline-setup.md (#240) * Update powerline-setup.md * Update powerline-setup.md * Update powerline-setup.md * fix typo * Merge release 1.7 into master (#264) Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Don-Vito <[email protected]> * Update powerline-setup.md (#175) * Update powerline-setup.md Updated Tips to include setting the Integrated terminal within Visual Studio to use the Cascadia Code Powerlines font. Also added an additional resource which shows step by step how to do this * Combine VS Code & VS tips for setting up powerline * Remove external blog link Co-authored-by: Matt Wojciakowski <[email protected]> * Fix a monor typo with the default keybinding for new tab (#287) closes #270 * Add a note that --window is only available in 1.7+ (#288) * Add a note that --window is only available in 1.7+ closes #282 * Whoops, those can't go on one line * Fix a typo in this doc (#289) * Fix a typo in this doc Closes #280 * I bet the docs build is gonna complain about this one * Add a FAQ entry for folks who are confused when Settings does nothing (#290) * Add a note that you can't set the tab color from the commandline (#291) Closes #249 * Add UUID generator option * Add online guid generator * Add instructions to open defaults.json file * Update panes.md * Add note about using settings.json... ..not defaults.json for applying color schemes across profiles. * fix link * Merge release-1.8 into master (#309) Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Don-Vito <[email protected]> Co-authored-by: Mike Griese <[email protected]> * Fix placement of unfocused appearance section (#312) * Update TerminalDocs/command-line-arguments.md * Update TerminalDocs/command-line-arguments.md * Add mouse interaction section (#297) Addresses issue #6 * document how to start windows terminal and have it execute a command (#298) * document how to start windows terminal and have it execute a command #296 * Separated the argument examples and included explanations of what they accomplish * fix typo * remove version from url Co-authored-by: Mark Iannucci <[email protected]> Co-authored-by: Matt Wojciakowski <[email protected]> * FIX syntax error in json configuration example (#308) FIX syntax error in json configuration example * Document trimBlockSelection setting (#313) * Document trimBlockSelection setting * Add preview disclaimer * Minor edit + note re how to select rectangular txt * Add preview to h2 Co-authored-by: Matt Wojciakowski <[email protected]> * Updated openSettings default bindings. (#317) * Updated openSettings default bindings. * Updated the openSettings description. * minor edits Co-authored-by: Matt Wojciakowski <[email protected]> * Update powerline-setup.md (#319) Fix a typo 'optonal' replaced by 'optional' * Updates for 1.9 release (#328) * Fix links * Typo "Windows terminal"→"Windows Terminal" (#326) https://docs.microsoft.com/en-us/windows/terminal/custom-terminal-gallery/custom-schemes #PingMSFTDocs * Add link to alternative install options (#321) Resolves #286 * Update `cursorHeight` minimum value (#278) Documentation update for microsoft/terminal#9386 * Add link to install preview (#342) * Add link to install preview * Update wording Co-authored-by: Kayla Cinnamon <[email protected]> * Update default settings, add UI screenshots (#343) * Update default settings, add UI screenshots * update screenshot * fix numbering * Fix screenshot steps * Correct title verbage, update screenshot * Add preview tags * Fix typos Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Samuel Bronson <[email protected]> Co-authored-by: LSC <[email protected]> Co-authored-by: skycommand <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Cameron Durham <[email protected]> Co-authored-by: Søren Fuglede Jørgensen <[email protected]> Co-authored-by: Janne Mareike Koschinski <[email protected]> Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Meenal Patel <[email protected]> Co-authored-by: Jan De Dobbeleer <[email protected]> Co-authored-by: Dakkaron <[email protected]> Co-authored-by: Ibrahim Rouis <[email protected]> Co-authored-by: Don-Vito <[email protected]> Co-authored-by: Michael James <[email protected]> Co-authored-by: Mark Iannucci <[email protected]> Co-authored-by: Mark Iannucci <[email protected]> Co-authored-by: lpotherat <[email protected]> Co-authored-by: Sean Jacobs <[email protected]> Co-authored-by: superfaz <[email protected]> Co-authored-by: Hiroshi Yoshioka <[email protected]> Co-authored-by: Eugene Samoylov <[email protected]>

@aloneguid

* command-line-arguments.md: Tag the Command Prompt code blocks For some reason they were tagged as bash, which broke highlighting in at least one of them. * fixed typo (#220) in line 98 it's `C:\\path\\to\\icon.png` while in line 115 it was `C:\\path\\to\\icon` so I've added the missing `.png` * Add note about escaping characters with backslash (#230) Originally filed by Andrewery https://github.com/MicrosoftDocs/terminal/pull/134/files * Add icon example and folder location (#231) From #135 * Add icon example and folder location As originally submitted by @aloneguid in #135 * Remove code brackets for readability * Add spacing * Fix default value by escaping characters (#232) Original submission: https://github.com/MicrosoftDocs/terminal/pull/134/files * Add info about the command palette (#180) * Add info about the command palette 1. Add info about the command palette. 2. Typo fixes (e.g. "quick-start guide" instead of "quickstart") 3. Style fix, e.g. we don't have a keyboard key whose full name is "alt+shift+plus". * revert description Co-authored-by: Matt Wojciakowski <[email protected]> * Add backslash escape note (#233) ...from PR #181 * Add a note about hiding dynamic profiles (#186) * Add a note about hiding dynamic profiles * Minor writing updates Co-authored-by: Matt Wojciakowski <[email protected]> * Clarify adding profile in ssh tutorial. Fixes #183 (#193) * Clarify adding profile in ssh tutorial. Fixes: #183 * Remove from docs link * Add guid command for powershell (#234) migrated from PR https://github.com/MicrosoftDocs/terminal/pull/199/files * Change "i.e." to "e.g." (#207) This seems to be the intended meaning: There are Linux distributions that are not Ubuntu, but Ubuntu is an example of a Linux distribution for which the behavior is the given. * Old Ubuntu: Use up-to-date version of golang (#216) Currently, the install recommends using an out-of-date version of golang, which in turn causes issues while installing powerline-go. * Add startingDirectory example (#237) * Add startingDirectory example * Format startingDirectory entry * remove icon file type Co-authored-by: Kayla Cinnamon <[email protected]> * Change icon description to example * Change false to true Co-authored-by: Kayla Cinnamon <[email protected]> * Remove unnecessary sentence Co-authored-by: Kayla Cinnamon <[email protected]> * Typo fixes Co-authored-by: Kayla Cinnamon <[email protected]> * link fix Co-authored-by: Kayla Cinnamon <[email protected]> * Capitalization fixes Co-authored-by: Kayla Cinnamon <[email protected]> * shortcut fixes Co-authored-by: Kayla Cinnamon <[email protected]> * page_title_updates_terminal (#243) * Add docs for `newWindow` action (#259) * refactor(powerline): update for oh-my-posh V3 (#263) * Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` (#123) Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` * Update powerline-setup.md (#240) * Update powerline-setup.md * Update powerline-setup.md * Update powerline-setup.md * fix typo * Merge release 1.7 into master (#264) Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Don-Vito <[email protected]> * Update powerline-setup.md (#175) * Update powerline-setup.md Updated Tips to include setting the Integrated terminal within Visual Studio to use the Cascadia Code Powerlines font. Also added an additional resource which shows step by step how to do this * Combine VS Code & VS tips for setting up powerline * Remove external blog link Co-authored-by: Matt Wojciakowski <[email protected]> * Fix a monor typo with the default keybinding for new tab (#287) closes #270 * Add a note that --window is only available in 1.7+ (#288) * Add a note that --window is only available in 1.7+ closes #282 * Whoops, those can't go on one line * Fix a typo in this doc (#289) * Fix a typo in this doc Closes #280 * I bet the docs build is gonna complain about this one * Add a FAQ entry for folks who are confused when Settings does nothing (#290) * Add a note that you can't set the tab color from the commandline (#291) Closes #249 * Add UUID generator option * Add online guid generator * Add instructions to open defaults.json file * Update panes.md * Add note about using settings.json... ..not defaults.json for applying color schemes across profiles. * fix link * Merge release-1.8 into master (#309) Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Don-Vito <[email protected]> Co-authored-by: Mike Griese <[email protected]> * Fix placement of unfocused appearance section (#312) * Update TerminalDocs/command-line-arguments.md * Update TerminalDocs/command-line-arguments.md * Add mouse interaction section (#297) Addresses issue #6 * document how to start windows terminal and have it execute a command (#298) * document how to start windows terminal and have it execute a command #296 * Separated the argument examples and included explanations of what they accomplish * fix typo * remove version from url Co-authored-by: Mark Iannucci <[email protected]> Co-authored-by: Matt Wojciakowski <[email protected]> * FIX syntax error in json configuration example (#308) FIX syntax error in json configuration example * Document trimBlockSelection setting (#313) * Document trimBlockSelection setting * Add preview disclaimer * Minor edit + note re how to select rectangular txt * Add preview to h2 Co-authored-by: Matt Wojciakowski <[email protected]> * Updated openSettings default bindings. (#317) * Updated openSettings default bindings. * Updated the openSettings description. * minor edits Co-authored-by: Matt Wojciakowski <[email protected]> * Update powerline-setup.md (#319) Fix a typo 'optonal' replaced by 'optional' * Updates for 1.9 release (#328) * Fix links * Typo "Windows terminal"→"Windows Terminal" (#326) https://docs.microsoft.com/en-us/windows/terminal/custom-terminal-gallery/custom-schemes #PingMSFTDocs * Add link to alternative install options (#321) Resolves #286 * Update `cursorHeight` minimum value (#278) Documentation update for microsoft/terminal#9386 * Add link to install preview (#342) * Add link to install preview * Update wording Co-authored-by: Kayla Cinnamon <[email protected]> * Update default settings, add UI screenshots (#343) * Update default settings, add UI screenshots * update screenshot * fix numbering * Fix screenshot steps * Correct title verbage, update screenshot * Add preview tags * Fix typos Co-authored-by: Kayla Cinnamon <[email protected]> * Add required version for OMP2 Oh-my-posh has updated to version 3, so adding a note to designate version 2 on this uninstall until we can return to this tutorial and update to version 3. In the meantime, there are other tutorials available on the web that walkthrough how to install OMP v3 and set it up with git status, etc. * Update quakemode monitor setting Based on #333 * Added link to Cascadia Code font * Add troubleshooting section on git bash flashing (#356) * font struct (#355) Co-authored-by: Pankaj Bhojwani <[email protected]> * documentation for minimzeToTray (#352) * Add documentation for closing tabs by index (#347) As implemented in microsoft/terminal#10447 * Update configuration section of get-start (#345) Select Settings in the dropdown menu will open the Settings UI instead of open file since the release version v1.6.10571.0 But this page is not up to date, so I edit it. * Add note about opening command palette via dropdown menu (#335) * Make link relative Co-authored-by: Samuel Bronson <[email protected]> Co-authored-by: LSC <[email protected]> Co-authored-by: skycommand <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Cameron Durham <[email protected]> Co-authored-by: Søren Fuglede Jørgensen <[email protected]> Co-authored-by: Janne Mareike Koschinski <[email protected]> Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Meenal Patel <[email protected]> Co-authored-by: Jan De Dobbeleer <[email protected]> Co-authored-by: Dakkaron <[email protected]> Co-authored-by: Ibrahim Rouis <[email protected]> Co-authored-by: Don-Vito <[email protected]> Co-authored-by: Michael James <[email protected]> Co-authored-by: Mark Iannucci <[email protected]> Co-authored-by: Mark Iannucci <[email protected]> Co-authored-by: lpotherat <[email protected]> Co-authored-by: Sean Jacobs <[email protected]> Co-authored-by: superfaz <[email protected]> Co-authored-by: Hiroshi Yoshioka <[email protected]> Co-authored-by: Eugene Samoylov <[email protected]> Co-authored-by: PankajBhojwani <[email protected]> Co-authored-by: Pankaj Bhojwani <[email protected]> Co-authored-by: Leon Liang <[email protected]> Co-authored-by: Ian O'Neill <[email protected]> Co-authored-by: Gaein_nidb <[email protected]> Co-authored-by: Casper Verhaar <[email protected]>

@aloneguid

* command-line-arguments.md: Tag the Command Prompt code blocks For some reason they were tagged as bash, which broke highlighting in at least one of them. * fixed typo (#220) in line 98 it's `C:\\path\\to\\icon.png` while in line 115 it was `C:\\path\\to\\icon` so I've added the missing `.png` * Add note about escaping characters with backslash (#230) Originally filed by Andrewery https://github.com/MicrosoftDocs/terminal/pull/134/files * Add icon example and folder location (#231) From #135 * Add icon example and folder location As originally submitted by @aloneguid in #135 * Remove code brackets for readability * Add spacing * Fix default value by escaping characters (#232) Original submission: https://github.com/MicrosoftDocs/terminal/pull/134/files * Add info about the command palette (#180) * Add info about the command palette 1. Add info about the command palette. 2. Typo fixes (e.g. "quick-start guide" instead of "quickstart") 3. Style fix, e.g. we don't have a keyboard key whose full name is "alt+shift+plus". * revert description Co-authored-by: Matt Wojciakowski <[email protected]> * Add backslash escape note (#233) ...from PR #181 * Add a note about hiding dynamic profiles (#186) * Add a note about hiding dynamic profiles * Minor writing updates Co-authored-by: Matt Wojciakowski <[email protected]> * Clarify adding profile in ssh tutorial. Fixes #183 (#193) * Clarify adding profile in ssh tutorial. Fixes: #183 * Remove from docs link * Add guid command for powershell (#234) migrated from PR https://github.com/MicrosoftDocs/terminal/pull/199/files * Change "i.e." to "e.g." (#207) This seems to be the intended meaning: There are Linux distributions that are not Ubuntu, but Ubuntu is an example of a Linux distribution for which the behavior is the given. * Old Ubuntu: Use up-to-date version of golang (#216) Currently, the install recommends using an out-of-date version of golang, which in turn causes issues while installing powerline-go. * Add startingDirectory example (#237) * Add startingDirectory example * Format startingDirectory entry * remove icon file type Co-authored-by: Kayla Cinnamon <[email protected]> * Change icon description to example * Change false to true Co-authored-by: Kayla Cinnamon <[email protected]> * Remove unnecessary sentence Co-authored-by: Kayla Cinnamon <[email protected]> * Typo fixes Co-authored-by: Kayla Cinnamon <[email protected]> * link fix Co-authored-by: Kayla Cinnamon <[email protected]> * Capitalization fixes Co-authored-by: Kayla Cinnamon <[email protected]> * shortcut fixes Co-authored-by: Kayla Cinnamon <[email protected]> * page_title_updates_terminal (#243) * Add docs for `newWindow` action (#259) * refactor(powerline): update for oh-my-posh V3 (#263) * Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` (#123) Improved title setting procedure on bash/Ubuntu so that it doesn't destroy `PS1` * Update powerline-setup.md (#240) * Update powerline-setup.md * Update powerline-setup.md * Update powerline-setup.md * fix typo * Merge release 1.7 into master (#264) Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Don-Vito <[email protected]> * Update powerline-setup.md (#175) * Update powerline-setup.md Updated Tips to include setting the Integrated terminal within Visual Studio to use the Cascadia Code Powerlines font. Also added an additional resource which shows step by step how to do this * Combine VS Code & VS tips for setting up powerline * Remove external blog link Co-authored-by: Matt Wojciakowski <[email protected]> * Fix a monor typo with the default keybinding for new tab (#287) closes #270 * Add a note that --window is only available in 1.7+ (#288) * Add a note that --window is only available in 1.7+ closes #282 * Whoops, those can't go on one line * Fix a typo in this doc (#289) * Fix a typo in this doc Closes #280 * I bet the docs build is gonna complain about this one * Add a FAQ entry for folks who are confused when Settings does nothing (#290) * Add a note that you can't set the tab color from the commandline (#291) Closes #249 * Add UUID generator option * Add online guid generator * Add instructions to open defaults.json file * Update panes.md * Add note about using settings.json... ..not defaults.json for applying color schemes across profiles. * fix link * Merge release-1.8 into master (#309) Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Don-Vito <[email protected]> Co-authored-by: Mike Griese <[email protected]> * Fix placement of unfocused appearance section (#312) * Update TerminalDocs/command-line-arguments.md * Update TerminalDocs/command-line-arguments.md * Add mouse interaction section (#297) Addresses issue #6 * document how to start windows terminal and have it execute a command (#298) * document how to start windows terminal and have it execute a command #296 * Separated the argument examples and included explanations of what they accomplish * fix typo * remove version from url Co-authored-by: Mark Iannucci <[email protected]> Co-authored-by: Matt Wojciakowski <[email protected]> * FIX syntax error in json configuration example (#308) FIX syntax error in json configuration example * Document trimBlockSelection setting (#313) * Document trimBlockSelection setting * Add preview disclaimer * Minor edit + note re how to select rectangular txt * Add preview to h2 Co-authored-by: Matt Wojciakowski <[email protected]> * Updated openSettings default bindings. (#317) * Updated openSettings default bindings. * Updated the openSettings description. * minor edits Co-authored-by: Matt Wojciakowski <[email protected]> * Update powerline-setup.md (#319) Fix a typo 'optonal' replaced by 'optional' * Updates for 1.9 release (#328) * Fix links * Typo "Windows terminal"→"Windows Terminal" (#326) https://docs.microsoft.com/en-us/windows/terminal/custom-terminal-gallery/custom-schemes #PingMSFTDocs * Add link to alternative install options (#321) Resolves #286 * Update `cursorHeight` minimum value (#278) Documentation update for microsoft/terminal#9386 * Add link to install preview (#342) * Add link to install preview * Update wording Co-authored-by: Kayla Cinnamon <[email protected]> * Update default settings, add UI screenshots (#343) * Update default settings, add UI screenshots * update screenshot * fix numbering * Fix screenshot steps * Correct title verbage, update screenshot * Add preview tags * Fix typos Co-authored-by: Kayla Cinnamon <[email protected]> * Add required version for OMP2 Oh-my-posh has updated to version 3, so adding a note to designate version 2 on this uninstall until we can return to this tutorial and update to version 3. In the meantime, there are other tutorials available on the web that walkthrough how to install OMP v3 and set it up with git status, etc. * Update quakemode monitor setting Based on #333 * Added link to Cascadia Code font * Add troubleshooting section on git bash flashing (#356) * font struct (#355) Co-authored-by: Pankaj Bhojwani <[email protected]> * documentation for minimzeToTray (#352) * Add documentation for closing tabs by index (#347) As implemented in microsoft/terminal#10447 * Update configuration section of get-start (#345) Select Settings in the dropdown menu will open the Settings UI instead of open file since the release version v1.6.10571.0 But this page is not up to date, so I edit it. * Add note about opening command palette via dropdown menu (#335) * Make link relative * Add updates for 1.10 release (#361) * Add reset settings to troubleshooting section Resolves #91 * Add 3rd party examples to dynamic profiles (#366) * Add experimental.input.forceVT setting to the interaction page (#367) * Add input.forceVT setting * Update wording * Replace screenshot with overview video * Add note about json vs UI settings for WSL starting directory Resolves #373 Co-authored-by: Samuel Bronson <[email protected]> Co-authored-by: LSC <[email protected]> Co-authored-by: skycommand <[email protected]> Co-authored-by: Mike Griese <[email protected]> Co-authored-by: Cameron Durham <[email protected]> Co-authored-by: Søren Fuglede Jørgensen <[email protected]> Co-authored-by: Janne Mareike Koschinski <[email protected]> Co-authored-by: Kayla Cinnamon <[email protected]> Co-authored-by: Meenal Patel <[email protected]> Co-authored-by: Jan De Dobbeleer <[email protected]> Co-authored-by: Dakkaron <[email protected]> Co-authored-by: Ibrahim Rouis <[email protected]> Co-authored-by: Don-Vito <[email protected]> Co-authored-by: Michael James <[email protected]> Co-authored-by: Mark Iannucci <[email protected]> Co-authored-by: Mark Iannucci <[email protected]> Co-authored-by: lpotherat <[email protected]> Co-authored-by: Sean Jacobs <[email protected]> Co-authored-by: superfaz <[email protected]> Co-authored-by: Hiroshi Yoshioka <[email protected]> Co-authored-by: Eugene Samoylov <[email protected]> Co-authored-by: PankajBhojwani <[email protected]> Co-authored-by: Pankaj Bhojwani <[email protected]> Co-authored-by: Leon Liang <[email protected]> Co-authored-by: Ian O'Neill <[email protected]> Co-authored-by: Gaein_nidb <[email protected]> Co-authored-by: Casper Verhaar <[email protected]>

Change cursor height number box to slider

f78b21e

ghost added Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Mar 5, 2021

eugenesmlv mentioned this pull request Mar 5, 2021

Represent Cursor Height as a slider #9383

Closed

6 tasks

zadjii-msft approved these changes Mar 5, 2021

View reviewed changes

ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 5, 2021

ghost added the Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) label Mar 5, 2021

carlos-zamora reviewed Mar 5, 2021

View reviewed changes

carlos-zamora removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 5, 2021

carlos-zamora reviewed Mar 5, 2021

View reviewed changes

carlos-zamora assigned DHowett and miniksa Mar 5, 2021

Restrict the minimum cursor height to 1px

d97a184

eugenesmlv commented Mar 9, 2021

View reviewed changes

carlos-zamora approved these changes Mar 9, 2021

View reviewed changes

carlos-zamora unassigned DHowett and miniksa Mar 9, 2021

carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 9, 2021

ghost merged commit 48d59e8 into microsoft:main Mar 9, 2021

eugenesmlv added a commit to eugenesmlv/terminal-docs that referenced this pull request Mar 9, 2021

Update cursorHeight minimum value

ee2780d

Documentation update for microsoft/terminal#9386

eugenesmlv mentioned this pull request Mar 9, 2021

Update cursorHeight minimum value MicrosoftDocs/terminal#278

Merged

This was referenced Apr 14, 2021

Allow "vintage" cursor to have values lower than 25 #9175

Closed

Represent Cursor Height as a slider #9377

Closed

mattwojo pushed a commit to MicrosoftDocs/terminal that referenced this pull request May 27, 2021

Update cursorHeight minimum value (#278)

cefb40f

Documentation update for microsoft/terminal#9386

This pull request was closed.

	// the following values are used to create the textmode cursor.
	static constexpr unsigned int CURSOR_SMALL_SIZE = 25; // large enough to be one pixel on a six pixel font

Conversation

eugenesmlv commented Mar 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Uh oh!

zadjii-msft left a comment

Choose a reason for hiding this comment

Uh oh!

zadjii-msft commented Mar 5, 2021

Uh oh!

ghost commented Mar 5, 2021

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

carlos-zamora Mar 5, 2021

Choose a reason for hiding this comment

Uh oh!

eugenesmlv Mar 5, 2021

Choose a reason for hiding this comment

Uh oh!

carlos-zamora Mar 5, 2021

Choose a reason for hiding this comment

Uh oh!

eugenesmlv Mar 6, 2021

Choose a reason for hiding this comment

Uh oh!

eugenesmlv commented Mar 5, 2021

Uh oh!

zadjii-msft commented Mar 8, 2021

Uh oh!

miniksa commented Mar 8, 2021

Uh oh!

eugenesmlv Mar 9, 2021

Choose a reason for hiding this comment

Uh oh!

carlos-zamora Mar 9, 2021

Choose a reason for hiding this comment

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Mar 9, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

eugenesmlv commented Mar 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zadjii-msft commented Mar 9, 2021

Uh oh!

miniksa commented Mar 9, 2021

Uh oh!

eugenesmlv commented Mar 9, 2021

Uh oh!

ghost commented Apr 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

eugenesmlv commented Mar 5, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

eugenesmlv commented Mar 9, 2021 •

edited

Loading