Perform polish of miscellaneous Settings UI bugs by carlos-zamora · Pull Request #9126 · microsoft/terminal

carlos-zamora · 2021-02-11T23:59:00Z

0b0dbdf Makes the browse buttons center vertically aligned
- This is now made possible by Represent inheritance in Settings UI #8919. The "center" used to include the height of the header. Now that it's separated, the center is solely calculated to be the text box.
- Closes Polish Settings UI: Profile page #8764
0288f06 Fix keyboard navigation focus for color schemes rename button
- Enter/Esc when in the scheme renamer now focuses the combo box
- Keyboard-invoking accept/cancel button focuses the rename button
- References Polish Settings UI: Color Scheme page #8765 and Polish Settings UI: Keyboard navigation (w/ tab key) #8768
d5ef552 Cyclical tab navigation
- now, if you try to tab past the save button, you cycle back to the beginning of the navigation view
- this is consistent with the xaml controls gallery
- References Polish Settings UI: Keyboard navigation (w/ tab key) #8768
a613b08 AutomationProperties for Save, Reset, and open json buttons
- References Add automation properties to Settings UI #8899

ghost · 2021-02-17T17:43:43Z

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

carlos-zamora added 2 commits February 11, 2021 14:44

Make buttons center-vertically aligned

0b0dbdf

Fix focus on CS rename keyboard interaction

0288f06

ghost added Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Feb 11, 2021

This comment has been minimized.

Sign in to view

carlos-zamora added 2 commits February 11, 2021 17:18

Force tab navigation to cycle on navigation view

d5ef552

Add automation properties to SettingsNav

a613b08

carlos-zamora mentioned this pull request Feb 12, 2021

Polish Settings UI: Keyboard navigation (w/ tab key) #8768

Closed

6 tasks

carlos-zamora marked this pull request as ready for review February 12, 2021 19:21

Merge branch 'main' into dev/cazamor/sui/style-polish

bc9eb09

zadjii-msft approved these changes Feb 17, 2021

View reviewed changes

carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Feb 17, 2021

ghost requested review from DHowett, PankajBhojwani, leonMSFT and miniksa February 17, 2021 17:39

DHowett approved these changes Feb 17, 2021

View reviewed changes

carlos-zamora added AutoMerge Marked for automatic merge by the bot when requirements are met and removed Needs-Second It's a PR that needs another sign-off labels Feb 17, 2021

ghost merged commit 557edc6 into main Feb 17, 2021

ghost deleted the dev/cazamor/sui/style-polish branch February 17, 2021 17:43

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Perform polish of miscellaneous Settings UI bugs#9126

Perform polish of miscellaneous Settings UI bugs#9126
5 commits merged intomainfrom
dev/cazamor/sui/style-polish

carlos-zamora commented Feb 11, 2021 •

edited

Loading

Uh oh!

This comment has been minimized.

ghost commented Feb 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

carlos-zamora commented Feb 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

ghost commented Feb 17, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

carlos-zamora commented Feb 11, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.