Move CharToKeyEvents (and friends) into InteractivityBase#9106
Merged
Conversation
ghost
added
Area-Build
Member
Author
|
This unblocks inbox. |
DHowett
commented
Feb 10, 2021
src/interactivity/base/convert.cpp
Outdated
| WORD CharType = 0; | ||
| GetStringTypeW(CT_CTYPE3, &wch, 1, &CharType); | ||
|
|
||
| if (WI_IsFlagSet(CharType, C3_ALPHA) || GetQuickCharWidth(wch) == CodepointWidth::Wide) |
Member
Author
There was a problem hiding this comment.
this is highly suspect -- the width of a character should not impact its encoding in key events. HOWEVER: this is NOT NEW CODE and I WILL NOT FIX IT HERE.
Member
There was a problem hiding this comment.
Yeah, don't fix it. But you're right. The width... shouldn't... ughhhhhh.
Member
Author
|
Pushing a revision that renames the new file from convert to EventSynthesis |
These functions have a dependency on the "VT Redirected" versions of VkKeyScanW, MapVirtualKeyW and GetKeyState. Those implementations depend on the service locator and therefore the entire interactivity stack. This meant that anybody depending on just Types had to pull in **the entire host** worth of dependencies (!). Since these functions are only used in places where we have or are testing interactivity, it makes sense to consolidate them here.
DHowett
force-pushed
the
dev/duhowett/move_vtredir_up
branch
from
4401d97 to
efd8ccf
Compare
miniksa
approved these changes
Feb 11, 2021
PankajBhojwani
approved these changes
Feb 11, 2021
DHowett
added a commit
that referenced
this pull request
Feb 11, 2021
These functions have a dependency on the "VT Redirected" versions of VkKeyScanW, MapVirtualKeyW and GetKeyState. Those implementations depend on the service locator and therefore the entire interactivity stack. This meant that anybody depending on just Types had to pull in **the entire host** worth of dependencies (!). Since these functions are only used in places where we have or are testing interactivity, it makes sense to consolidate them here. (cherry picked from commit 8f73145)
DHowett
added a commit
that referenced
this pull request
Feb 11, 2021
Dustin L. Howett (3) * Move CharToKeyEvents (and friends) into InteractivityBase (GH-9106) * Update Cascadia Code to 2102.03 (GH-9088) * verison: bump to 1.7 on main Josh Soref (1) * ci: update to Spell check to 0.0.17a (CC-9014) Leonard Hecker (3) * Fixed GH-5205: Ctrl+Alt+2 doesn't send ^[^@ (CC-5272) * Fix issues in tests.xml and OpenConsole.psm1 (CC-9011) * Fix GH-8458: Handle all Ctrl-key combinations (CC-8870) Mike Griese (1) * Add support for running a commandline in another WT window (GH-8898) Michael Niksa (1) * Teach the renderer to keep thread alive if engine requests it (GH-9091) Lachlan Picking (1) * Fix shader time input (CC-8994) PankajBhojwani (1) * Separate runtime TerminalSettings from profile-TerminalSettings (CC-8602) Chester Liu (2) * Add support for paste filtering and bracketed paste mode (CC-9034) * Add support for chaining OSC 10-12 (CC-8999) Related work items: MSFT-31692939
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions have a dependency on the "VT Redirected" versions of
VkKeyScanW, MapVirtualKeyW and GetKeyState. Those implementations depend
on the service locator and therefore the entire interactivity stack.
This meant that anybody depending on just Types had to pull in the
entire host worth of dependencies (!).
Since these functions are only used in places where we have or are
testing interactivity, it makes sense to consolidate them here.
Closes #9105.