Skip to content

Fix hyperlink not de-underlined in unfocused pane#9039

Merged
DHowett merged 1 commit intomicrosoft:mainfrom
Don-Vito:8925-fix-underline-unfocused
Feb 5, 2021
Merged

Fix hyperlink not de-underlined in unfocused pane#9039
DHowett merged 1 commit intomicrosoft:mainfrom
Don-Vito:8925-fix-underline-unfocused

Conversation

@Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Feb 4, 2021 •
edited by DHowett
Loading

Ensures that:

  • All hyperlink related logic is running on unfocused pane
  • All unrelated logic is not running on unfocused pane

Closes #8925

@ghost ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Feb 4, 2021
PankajBhojwani
PankajBhojwani approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@PankajBhojwani PankajBhojwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@carlos-zamora carlos-zamora added zPreview-Service-Consider AutoMerge Marked for automatic merge by the bot when requirements are met labels Feb 4, 2021
@ghost
Copy link

ghost commented Feb 4, 2021

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 4 hours 25 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

DHowett
DHowett approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks!

@DHowett DHowett merged commit 40e3289 into microsoft:main Feb 5, 2021
DHowett pushed a commit that referenced this pull request Feb 5, 2021
@Don-Vito @DHowett
Fix hyperlink not de-underlined in unfocused pane (#9039)
b80f6de 
Ensures that:
* All hyperlink related logic is running on unfocused pane
* All unrelated logic is not running on unfocused pane

Closes #8925

(cherry picked from commit 40e3289)
@ghost
Copy link

ghost commented Feb 11, 2021

🎉Windows Terminal Preview v1.6.10412.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Feb 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

Assignees

No one assigned

Labels

Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

De-underline hyperlink on hover-out, even if not focused

4 participants

@Don-Vito @DHowett @carlos-zamora @PankajBhojwani