Merged
Conversation
…t away with only dismissing selection on key _down_. Otherwise keyups will dismiss the selection you just made
ghost
added
Area-Settings
6 tasks
Member
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
I just want a little bit of discussion on the keybinding arg thing before approving. The code is solid. Don't feel strongly enough on these topics to block though.
Don-Vito
reviewed
Jan 29, 2021
carlos-zamora
approved these changes
Feb 4, 2021
ghost
requested review from
miniksa
approved these changes
Feb 4, 2021
Member
|
Don't forget to update the docs plz |
DHowett
requested changes
Feb 5, 2021
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
Okay, I only have one concern. This is great otherwise.
|
|
||
| void CreateSearchBoxControl(); | ||
|
|
||
| void SearchMatch(Boolean goForward); |
Member
There was a problem hiding this comment.
it's a weird public API, but i suppose that this is fine
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
DHowett
reviewed
Feb 18, 2021
zadjii-msft
commented
Feb 18, 2021
DHowett
approved these changes
Feb 18, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a resurrection of #8522. @Hegunumo has apparently deleted
their account, but the contribution was still valuable. I'm just here to
get it across the finish line.
This PR adds new action for navigating to the next & previous search
results. These actions are unbound by default. These actions can be used
from directly within the search dialog also, to immediately navigate the
results.
Furthermore, if you have a search started, and close the search box,
then press this keybinding, it will still perform the search. So you
can just hit F3 repeatedly with the dialog closed to keep
searching new results. Neat!
If you dispatch the action on the key down, then dismiss a selection on
a key up, we'll end up immediately destroying the selection when you
release the bound key. That's annoying. It also bothers @carlos-zamora
in #3758. However, I think we can just only dismiss the selection on a
key up. I think that's fine. It seems fine so far. We've got an
entire release cycle to futz with it.
Validation Steps Performed
I've played with it all day and it seems crisp.
Closes #7695
Co-authored-by: Kiminori Kaburagi [email protected]