Bugfix: navigate to new profile ref on settings reload#8835
Merged
1 commit merged intomainfrom Jan 21, 2021
Merged
Conversation
carlos-zamora
added
Product-Terminal
PankajBhojwani
approved these changes
Jan 21, 2021
Member
Author
|
@msftbot merge this in 5 minutes |
ghost
added
the
AutoMerge
|
Hello @carlos-zamora! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
Upon a settings reload, we would select the correct navigation item for a profile, but navigate to the old one. As a result, you would navigate to the old page that points to a dead profile object. This would make it appear like you did not discard/save the changes. This bugfix navigates to the newly created profile, ensuring that your changes are actually applied to the settings model's clone in use. ## References microsoft#8773 - Introduced the bug microsoft#6800 - Settings UI Epic ## Validation Steps Performed - Navigate to "powershell" profile - edit "tab title" value - discard changes Before: changes would persist unless you discarded changes again Now: changes are discarded Also verified expected behavior occurs when you click "save" instead of "discard"
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon a settings reload, we would select the correct navigation item for
a profile, but navigate to the old one. As a result, you would navigate
to the old page that points to a dead profile object. This would make it
appear like you did not discard/save the changes.
This bugfix navigates to the newly created profile, ensuring that your
changes are actually applied to the settings model's clone in use.
References
#8773 - Introduced the bug
#6800 - Settings UI Epic
Validation Steps Performed
Before: changes would persist unless you discarded changes again
Now: changes are discarded
Also verified expected behavior occurs when you click "save" instead of
"discard"