Merged
Conversation
ghost
added
Area-SettingsUI
carlos-zamora
approved these changes
Jan 13, 2021
Member
Validation Steps Performed
|
DHowett
reviewed
Jan 14, 2021
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
DHowett
reviewed
Jan 14, 2021
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
DHowett
reviewed
Jan 14, 2021
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
DHowett
reviewed
Jan 14, 2021
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
cinnamon-msft
suggested changes
Jan 14, 2021
Contributor
cinnamon-msft
left a comment
cinnamon-msft
left a comment
There was a problem hiding this comment.
Added some wordsmithing :)
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
Contributor
Author
Thank you! Fixed |
cinnamon-msft
approved these changes
Jan 14, 2021
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
PankajBhojwani
added
the
AutoMerge
|
Hello @PankajBhojwani! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
cinnamon-msft
suggested changes
Jan 14, 2021
Contributor
cinnamon-msft
left a comment
cinnamon-msft
left a comment
There was a problem hiding this comment.
Wait actually, alwaysOnTop should be an appearance setting, rather than a startup setting.
ghost
added
the
Needs-Author-Feedback
cinnamon-msft
removed
the
AutoMerge
ghost
removed
the
Needs-Author-Feedback
cinnamon-msft
approved these changes
Jan 14, 2021
PankajBhojwani
added
the
AutoMerge
ghost
merged commit
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
Adds the tab switcher mode setting and copy format setting to the SUI Closes microsoft#8755
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the tab switcher mode setting and copy format setting to the SUI
Closes #8755