Conversation
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Okay I don't see anything wrong with this. Maybe add more comments? This is how I'd do it, so I'm gonna give you the ✔️
| const auto result = _appArgs.ParseArgs(args); | ||
| if (result == 0) | ||
| { | ||
| _hasCommandLineStartupActions = args.size() > 1; |
There was a problem hiding this comment.
Maybe we should leave a comment that this is explicitly > 1, so that wt by itself will not count as having a startup commandline?
There was a problem hiding this comment.
@zadjii-msft - I will document this for sure! Thanks!
Actually, I had a question regarding the decision I took here - the startupActions will be run only if no arguments were provided at all (I mean the launchMode will also prevent the startupActions to run).
It felt simpler to understand and implement, but not sure if it was the right choice.
zadjii-msft
added
Area-Settings
ghost
requested review from
DHowett,
PankajBhojwani,
carlos-zamora,
leonMSFT and
miniksa
carlos-zamora
left a comment
carlos-zamora
left a comment
There was a problem hiding this comment.
Awesome! Created #8802 to track adding this to the Settings UI. Since the Settings UI is new, @zadjii-msft and I decided that there shouldn't be an expectation to update it. But if you're interested in doing so, let us know!
Absolutely, this will be a great opportunity to learn! Can you please assign #8802 to me? 😊 I guess it is probably better to solve it in a separate PR. |
Sure thing! Shouldn't be too difficult (famous last words). May just include a bit more back-and-forth on the design (i.e. placement of the setting, word-smithing, etc.). Fair warning! hahaha. I appreciate it though 😊 |
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Procedural solution for microsoft#756. Introduces a `startupActions` global setting. This setting is as string with the same format as actions in command line arguments. It is used only if command line arguments were not provided (aka running pure wt.exe). The setting allows implicit new-tabs. In the case of invalid syntax we show the warning dialog and ignore the setting. The documentation PR is here: MicrosoftDocs/terminal#217
3 participants
Procedural solution for #756.
Introduces a
startupActionsglobal setting.This setting is as string with the same format as actions in command line arguments.
It is used only if command line arguments were not provided
(aka running pure wt.exe).
The setting allows implicit new-tabs.
In the case of invalid syntax we show the warning dialog and ignore the setting.
The documentation PR is here: MicrosoftDocs/terminal#217