Fix Korean IME to display a character being composed in conhost#8632
Fix Korean IME to display a character being composed in conhost#86321 commit merged intomicrosoft:mainfrom
Conversation
|
I manually tested on Korean, Japanese, and Chinese IME, and found that only when using Korean IME, the Meanwhile, in Korean, the maximum number of interim character is 1, so the values of However, I don't know the background of this code being written this way, so I'm not sure if my changes won't cause problems when typing in Japanese and Chinese. |
da22201 to
ff98d0f
Compare
|
@MycroftKang, thank you for taking a look at this. I really appreciate it. I'm out of the office, though, until January 4th. My plan is to dig through the code history then and make sure that this shouldn't cause a problem. Thank you in advance for your patience! |
|
@msftbot make sure @miniksa signs off on this |
|
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
zadjii-msft
left a comment
There was a problem hiding this comment.
This seems reasonable to me, assuming that miniksa's investigation doesn't find anything alarming
|
OK. I did the history search. It looks like it was always rejecting anything that wasn't 1 for this particular check back through the v1 conhost. However, the v1 conhost also had a bit of divergence for Chinese, Japanese, and Korean right up at the top that went down 4 different mechanisms that I had unified way back in something like 2015 because they were 95% the same. It could be that I made this mistake in the unification of the interfaces but that code is a bit harder to analyze. However, on looking at how it's used and operates, I'm fine with it just switching to not throwing the error since it appears to resolve Korean and doesn't appear to immediately impact Chinese or Japanese. If something comes up as fall out later, I think we can further work it out at that time. |
|
Automerge off. @DHowett is going to check this against UNIVERSAL WUBI before commit. |
|
Woops. He'll check it after the fact. |
|
Validated. Thanks again for the fix. |
…osoft#8632) ## Summary of the Pull Request This PR fixes Korean IME to display a character being composed in conhost. ### Before  ### After  <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes microsoft#6227 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
|
This turned into OS PR !5568527, which made it to |
Summary of the Pull Request
This PR fixes Korean IME to display a character being composed in conhost.
Before
After
PR Checklist
Validation Steps Performed