Skip to content

Enable underlining hyperlink on hover even if not focused#8615

Merged
2 commits merged intomainfrom
unknown repository
Jan 7, 2021
Merged

Enable underlining hyperlink on hover even if not focused#8615
2 commits merged intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Dec 18, 2020 •
edited by DHowett
Loading

Closes #8475

@ghost ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Dec 18, 2020
@ghost ghost closed this Dec 28, 2020
@DHowett
Copy link
Member

DHowett commented Dec 30, 2020

What happened? We aren’t ignoring you, the team is on vacation for the rest of the year. You can leave your pull request open and we will review it when we are back in the office!

@ghost ghost reopened this Dec 31, 2020
@zadjii-msft zadjii-msft self-assigned this Jan 4, 2021
PankajBhojwani
PankajBhojwani reviewed Jan 5, 2021
View reviewed changes
src/cascadia/TerminalControl/TermControl.cpp
const auto ptr = args.Pointer();
const auto point = args.GetCurrentPoint(*this);
const auto cursorPosition = point.Position();
const auto terminalPosition = _GetTerminalPosition(cursorPosition);
Copy link
Contributor

@PankajBhojwani PankajBhojwani Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: with these 2 declarations here, the cursorPosition and terminalPos declarations below (lines 1369 and 1412) can be removed

zadjii-msft
zadjii-msft approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but I agree with Pankaj. We should remove the redundant declarations below now.

@zadjii-msft zadjii-msft removed their assignment Jan 7, 2021
@DHowett
Copy link
Member

DHowett commented Jan 7, 2021

I made the requested changes. This PR is 20 days old and I don't want to make @Hegunumo spend another cycle on it. 😄

@DHowett DHowett changed the title Enable underlining hyperlink on hover nonetheless if not focused Enable underlining hyperlink on hover even if not focused Jan 7, 2021
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 7, 2021
@ghost
Copy link

ghost commented Jan 7, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit cceb0ea into microsoft:main Jan 7, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

🎉Windows Terminal Preview v1.6.10272.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 28, 2021
Closed
mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
@kaihugo @mpela81
Enable underlining hyperlink on hover even if not focused (microsoft#…
4328279 
…8615)

Closes microsoft#8475
@PhMajerus PhMajerus mentioned this pull request Jan 28, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@PankajBhojwani PankajBhojwani

Labels

Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Underline hyperlink on hover, even if not focused

5 participants

@DHowett @zadjii-msft @PankajBhojwani @amanda008868 @kaihugo