Fix SwitchToTab build break#8545
Merged
DHowett merged 1 commit intofeature/settings-uifrom Dec 10, 2020
Merged
Conversation
ghost
added
Area-UserInterface
DHowett
approved these changes
Dec 10, 2020
Member
|
The new SA failures are due to VS 16.8. |
zadjii-msft
approved these changes
Dec 10, 2020
Contributor
|
The fix is perfect! Please let me know if I can help somehow 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8420 removed
SwitchToTab()as a responsibility ofTabBaseand replaces_mruTabActionswith_mruTabs(conceptually). This PR fixes the build break by...TerminalPage's reference to the SettingsTab's SwitchToTab command, with a reference to the tab itselfReferences
#1564 - Settings UI
#8420 - Command Palette + SwitchToTab refactoring
PR Checklist
Validation Steps Performed
✅ Open SUI --> switch to a different tab --> try opening SUI again --> switches to existing SUI
✅ Open SUI --> switch to a different tab --> reorder tabs --> try opening SUI again --> switches to existing SUI