Skip to content

Always create and link profiles.defaults object#8445

Merged
3 commits merged intomainfrom
dev/cazamor/tsm/always-create-pd-object
Dec 1, 2020
Merged

Always create and link profiles.defaults object#8445
3 commits merged intomainfrom
dev/cazamor/tsm/always-create-pd-object

Conversation

@carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Nov 30, 2020 •
edited by DHowett
Loading

The Settings UI exposes the profiles.defaults (PD) object. Today, we
remove PD if there's nothing in it. However, that causes problems with
the Settings UI, because we have no Profile object to bind to
(resulting in a crash). Rather than making the Settings UI create a PD,
and link it in the inheritance tree, it's much easier to just always
create and link the PD object.

References

#1564 - Settings UI (fixes a crash for this)
#7923 - Introduces inheritance

PR Checklist

  • Tests added/passed

Validation Steps Performed

  • repro steps for crash in Settings UI (copied changes over to that
    branch for testing)
  • tests passed

@carlos-zamora
Copy link
Member Author

carlos-zamora commented Nov 30, 2020

The modified tests from 0005138 have now been verified 😊

DHowett
DHowett reviewed Nov 30, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 30, 2020
@ghost
Copy link

ghost commented Nov 30, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 40 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Nov 30, 2020

@msftbot merge this in 2 minutes

@ghost
Copy link

ghost commented Nov 30, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Mon, 30 Nov 2020 22:16:34 GMT, which is in 2 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 6213172 into main Dec 1, 2020
@ghost ghost deleted the dev/cazamor/tsm/always-create-pd-object branch December 1, 2020 14:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

No one assigned

Labels

AutoMerge Marked for automatic merge by the bot when requirements are met

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlos-zamora @DHowett @zadjii-msft