Skip to content

tools: update bcz.cmd to use the progress bar VT sequence#8335

Merged
DHowett merged 2 commits intomainfrom
dev/migrie/f/bcz-progress
Nov 20, 2020
Merged

tools: update bcz.cmd to use the progress bar VT sequence#8335
DHowett merged 2 commits intomainfrom
dev/migrie/f/bcz-progress

Conversation

@zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Nov 19, 2020

Summary of the Pull Request

Does what the title says. Now while you're building terminal projects,
the taskbar will show indeterminate progress. If the build fails, it'll
blink the error state for 500ms before returning to normal.

References

PR Checklist

  • scratches an itch I've had since at least 2018
  • I work here
  • this is a build script

Validation Steps Performed

tested manually

@zadjii-msft zadjii-msft added the Area-Build Issues pertaining to the build system, CI, infrastructure, meta label Nov 19, 2020
@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Nov 20, 2020
@ghost ghost requested review from DHowett, carlos-zamora, leonMSFT and miniksa November 20, 2020 16:33
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is, of course, madness.

@DHowett DHowett changed the title Update bcz.cmd to use the progress bar VT sequence tools: update bcz.cmd to use the progress bar VT sequence Nov 20, 2020
@DHowett DHowett merged commit 14fe993 into main Nov 20, 2020
@DHowett DHowett deleted the dev/migrie/f/bcz-progress branch November 20, 2020 17:26
mpela81 pushed a commit to mpela81/terminal that referenced this pull request Nov 22, 2020
…8335)

## Summary of the Pull Request

Does what the title says. Now while you're building terminal projects,
the taskbar will show indeterminate progress. If the build fails, it'll
blink the error state for 500ms before returning to normal.

## References
* Made possible by microsoft#8055 _and viewers like you_

## PR Checklist
* [x] scratches an itch I've had since at least 2018
* [x] I work here
* [x] this is a build script

## Validation Steps Performed
tested manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Build Issues pertaining to the build system, CI, infrastructure, meta Needs-Second It's a PR that needs another sign-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants