Fix close button not using the tab's text color (#8046)#8209
Merged
1 commit merged intomicrosoft:mainfrom Nov 18, 2020
dcheatha:close-button-doesnt-use-a-tabs-text-color-when-hovered-8044
Merged
Fix close button not using the tab's text color (#8046)#82091 commit merged intomicrosoft:mainfrom dcheatha:close-button-doesnt-use-a-tabs-text-color-when-hovered-8044
1 commit merged intomicrosoft:mainfrom
dcheatha:close-button-doesnt-use-a-tabs-text-color-when-hovered-8044
Conversation
ghost
added
Area-UserInterface
zadjii-msft
approved these changes
Nov 10, 2020
Contributor
|
@zadjii-msft , @dcheatha - I guess this one is blocked on the conflict - the name of the Tab was changed to TerminalTab |
zadjii-msft
added
the
Needs-Author-Feedback
Member
|
@dcheatha can you take care of the conflict? It shouldn't be too bad considering it's really just a renamed file that git can't follow 🤷♂️ |
ghost
removed
the
Needs-Author-Feedback
Contributor
Author
|
@zadjii-msft Hi, I rebased the commit off of main. I hope that's okay! |
ghost
requested review from
DHowett,
PankajBhojwani,
carlos-zamora,
leonMSFT and
miniksa
carlos-zamora
approved these changes
Nov 18, 2020
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
dcheatha
deleted the
close-button-doesnt-use-a-tabs-text-color-when-hovered-8044
branch
DHowett
pushed a commit
that referenced
this pull request
Jan 25, 2021
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This sets the tab close button color to match the tab text color. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #8046 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #8046 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #8046 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments This sets the tab close button color to match the tab text color. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Test light theme white tab mouse hover effect:  Test dark theme white tab mouse hover effect:  (cherry picked from commit 2a34080)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This sets the tab close button color to match the tab text color.
References
#8046
PR Checklist
Detailed Description of the Pull Request / Additional comments
This sets the tab close button color to match the tab text color.
Validation Steps Performed
Test light theme white tab mouse hover effect:
Test dark theme white tab mouse hover effect:
