Skip to content

sync tabs and focus after close a tab#818

Closed
bef178 wants to merge 2 commits intomicrosoft:masterfrom
bef178:sync-tabs-focus
Closed

sync tabs and focus after close a tab#818
bef178 wants to merge 2 commits intomicrosoft:masterfrom
bef178:sync-tabs-focus

Conversation

@bef178
Copy link
Contributor

@bef178 bef178 commented May 15, 2019

Should fix #816
Should go with #737

@bef178
Copy link
Contributor Author

bef178 commented May 15, 2019

Manual test cases:

open tab a,b,c,d
activate a
ctrl-w
ctrl-w
expect c is shown and is the only highlight in tabview

open tab a,b,c,d
activate a
mouse close a
mouse close b
expect c is shown and is the only highlight in tabview

open tab a,b,c,d
activate c
mouse close a
expect c is shown and is the only highlight in tabview
alt-1
expect b is shown and is the only highlight in tabview

open tab a,b,c,d
activate c
mouse close a
expect c is shown and is the only highlight in tabview
mouse activate b
expect b is shown and is the only highlight in tabview

open tab a,b,c,d,e
activate c
ctrl-w
ctrl-w
ctrl-w
expect d is shown and is the only highlight in tabview
ctrl-w
expect e is shown and tabview is hided

@bef178
Copy link
Contributor Author

bef178 commented May 18, 2019

Thanks @zadjii. Is there any thing need to be changed? @miniksa

@bef178
Copy link
Contributor Author

bef178 commented May 23, 2019

Closing since the related issue #816 is closed.

@bef178 bef178 closed this May 23, 2019
@miniksa
Copy link
Member

miniksa commented May 23, 2019

Sorry, @bef178, I get a ton of mail these days. I didn't get back to this until now. It looks like there was another pull that solved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Close an unfocused tab (using mouse) results in focus switched

3 participants