8167: Fix TabTests - use tab 0 rather than value 0#8168
Conversation
|
@DHowett - we really need to make those tests run in CI |
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
Good catch! I hate that the compiler didn't even catch this one 😑
zadjii-msft
added
AutoMerge
ghost
requested review from
DHowett,
PankajBhojwani,
carlos-zamora,
leonMSFT and
miniksa
|
Hello @zadjii-msft! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 5 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot merge this in 4 minutes |
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
I guess we need to rerun CI.. again.. |
|
The weird thing is that it's a different set each time. I'm not certain I want to disable that many tests for this weird infrastructure issue. Curious about what's happening though... |
Locally I am running with /breakOnError which invokes Windbg. Probably we can do something similar. |
|
🎉 Handy links: |
ghost
mentioned this pull request
4 participants
A fix for UTs crashing due to bad memory access (accessing page 0).
Regression from #8153
Closes #8167