Make the link underline less obtrusive; don't use it for pattern#8148
Merged
Make the link underline less obtrusive; don't use it for pattern#8148
Conversation
ghost
added
Area-Rendering
PankajBhojwani
approved these changes
Nov 3, 2020
Contributor
PankajBhojwani
left a comment
PankajBhojwani
left a comment
There was a problem hiding this comment.
Looks good to me! Should we file a follow up for a setting to underline auto detected links?
22 tasks
Member
Probably yea. Maybe we should consider allowing people to customize how auto-detected hyperlinks are highlighted? Like, they could be underlined, or they could be underlined and blue, or they could be bold, or... |
Member
Author
|
If we solve it like that, we must solve |
Member
|
okay yes, I was mostly just listing off a list of possible attributes. Could be reversed. Double underline. Of course, I picked the two we don't implement 😆 |
Member
Author
|
Oh yeah. What I mean is more like, "I as a user want to set the font for [this attribute]". 😄 |
DHowett
changed the title
DHowett
added a commit
that referenced
this pull request
Nov 3, 2020
This pull request switches up the treatment we use for pattern-detected
links and OSC 8 hyperlinks:
* Links generated via OSC 8 have a sparse dotted underline instead of a
thick dashed one
* Links generated by pattern detection _are not underlined until they've
hovered_
* This papers over a visual glitch that is a result of us updating
the pattern matches every ~500ms (on change)
Closes #8123
(cherry picked from commit 26ca73b)
|
🎉 Handy links: |
|
🎉 Handy links: |
DHowett
added a commit
that referenced
this pull request
Nov 16, 2020
* Run all images through ImgBot (CC-8169) * Fix potential over/underflow as noted by "TODO:" comment (CC-8081) * Fix garbling when copying multibyte text via OSC 52 (CC-7870) * UIA: throw E_FAIL for out-of-bounds text (CC-8052) * Consider the GlyphWidth when calculate the postion of matched word in URL detecting (CC-8124) * Make the link underline less obtrusive; don't use it for pattern (GH-8148) * Fully regenerate CodepointWidthDetector from Unicode 13.0 (GH-8035) * Prepare for the primary branch name to change to main (GH-7985) * Hash the URI as part of the hyperlink ID (GH-7940) * Introduce til::presorted_static_map (GH-7640) * Prevent leftover cursor fragments when scrolling in PowerShell (CC-8173) * Add support for the DECREQTPARM report (CC-7939) * Refactor VT parameter handling (CC-7799) * Add support for the "blink" graphic rendition attribute (CC-7490) * Combine the parsing & dispatch blocks for OSC actions (CC-8202) * Add support for autodetecting URLs and making hyperlinks (CC-7691) * Copy _currentHyperlinkId when copying the buffer (CC-8074) * Fix the "visual representation" optimization for hyperlinks (CC-7738) * Optimize the binary size of the XOrg color table (CC-7929) * Add support for more OSC color formats (CC-7578) Related work items: MSFT-30259074
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request switches up the treatment we use for pattern-detected
links and OSC 8 hyperlinks:
thick dashed one
hovered
the pattern matches every ~500ms (on change)
Closes #8123