Add missing settings to Settings UI#8116
Merged
carlos-zamora merged 4 commits intofeature/settings-uifrom Oct 30, 2020
Merged
Conversation
Contributor
|
Pics or it didn't happen |
Member
Author
LaunchMode: Bell style (under advanced): Visual animations: |
Contributor
|
I'm wondering if the BEL setting should just be a checkbox? Unless we're planning to add additional styles? |
Member
Other things we've considered:
|
Contributor
Ah okay, lgtm then :) |
cinnamon-msft
approved these changes
Oct 30, 2020
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
Co-authored-by: Kayla Cinnamon <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Since we've started working on the Settings UI, a few settings have been added on
main. This adds those missing settings over.References
Missing settings include...
disableAnimationslaunchModefocusandmaximizedFocusbellStyleValidation Steps Performed
Verified that those settings appear properly in the Settings UI.