Conversation
zadjii-msft
added
Area-Build
DHowett
approved these changes
Oct 28, 2020
Contributor
|
So actually in this case, i think we need to add our own linter rules. If you see https://www.npmjs.com/package/eslint-plugin-json-format, this is what VSCode uses to lint jsonc files. We just need to update the plugin field. This will ignore the comments and simply lint the actual json. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All our JSON files are actually JSONC files - json with comments.
A well-behaved application that accepts JSON should accept and ignore comments. However,
jsonlintis not a well behaved application in this regard.So, to prevent the linter from complaining about our JSON comments, we need to disable it entirely. THAT'S RIGHT, there's not a setting to allow JSONC.
See #8076 as an example of this working.
This will also unblock #7462.