Skip to content

Store and expose hidden profiles#8070

Merged
3 commits merged intomainfrom
dev/cazamor/tsm/hidden-vs-active-profiles
Oct 28, 2020
Merged

Store and expose hidden profiles#8070
3 commits merged intomainfrom
dev/cazamor/tsm/hidden-vs-active-profiles

Conversation

@carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Oct 28, 2020 •
edited
Loading

Summary of the Pull Request

This PR replaces CascadiaSettings::_profiles with...

  • _allProfiles: the list of all available profiles in the settings model (i.e. settings.json, dynamic profiles, etc...)
  • _activeProfiles: the list of all non-hidden profiles (used for the new tab dropdown)

References

#8018: maintaining a list of all profiles allows us to serialize hidden profiles
#1564: Settings UI can link to AllProfiles() instead of ActiveProfiles() to expose hidden profiles

PR Checklist

Validation Steps Performed

Deploy and testing succeeded

@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Oct 28, 2020
@carlos-zamora

This comment has been minimized.

Sign in to view
@carlos-zamora carlos-zamora force-pushed the dev/cazamor/tsm/hidden-vs-active-profiles branch from 0552641 to 6baa453 Compare October 28, 2020 04:01
@carlos-zamora carlos-zamora marked this pull request as ready for review October 28, 2020 04:02
DHowett
DHowett approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with this.

@DHowett
Copy link
Member

DHowett commented Oct 28, 2020

Make sure that wt -p {HIDDEN PROFILE} works now (!) (it was an explicit request from #4139)

@carlos-zamora
Copy link
Member Author

carlos-zamora commented Oct 28, 2020

Make sure that wt -p {HIDDEN PROFILE} works now (!) (it was an explicit request from #4139)

Verified! Works like a charm! 😊

zadjii-msft
zadjii-msft approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was easier than I thought it would be

@carlos-zamora
Copy link
Member Author

carlos-zamora commented Oct 28, 2020

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 28, 2020
@ghost
Copy link

ghost commented Oct 28, 2020

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 28 Oct 2020 16:21:32 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 242833f into main Oct 28, 2020
@ghost ghost deleted the dev/cazamor/tsm/hidden-vs-active-profiles branch October 28, 2020 16:22
@carlos-zamora carlos-zamora restored the dev/cazamor/tsm/hidden-vs-active-profiles branch October 28, 2020 16:51
@carlos-zamora carlos-zamora deleted the dev/cazamor/tsm/hidden-vs-active-profiles branch October 28, 2020 16:55
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal Preview v1.5.3142.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 11, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees

No one assigned

Labels

Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hidden profiles are deleted, not hidden

3 participants

@carlos-zamora @DHowett @zadjii-msft