Hook up the Settings UI ColorSchemes page#8049
Merged
DHowett merged 9 commits intofeature/settings-uifrom Oct 27, 2020
Merged
Conversation
DHowett
reviewed
Oct 26, 2020
DHowett
reviewed
Oct 26, 2020
DHowett
reviewed
Oct 27, 2020
DHowett
reviewed
Oct 27, 2020
DHowett
reviewed
Oct 27, 2020
miniksa
reviewed
Oct 27, 2020
miniksa
approved these changes
Oct 27, 2020
DHowett
approved these changes
Oct 27, 2020
Member
|
admin override: FT failure in the flaky utf8 FTs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fleshes out the Settings UI's ColorSchemes page so that it's
able to display all your defined color schemes. It'll allow the user to
modify all the colors of the scheme through either a color picker or
entering a hex color in the TextBoxes. If the user enters an invalid hex
code, the TextBox will automatically revert back to the original hex.
Since we haven't hooked up the save button just yet, making any changes
to a color scheme will modify the color scheme only for the currently
open Terminal instance.
References #1564