Skip to content

Add localization to settings tab#8012

Merged
2 commits merged intofeature/settings-uifrom
cinnamon/localization-fix
Oct 22, 2020
Merged

Add localization to settings tab#8012
2 commits merged intofeature/settings-uifrom
cinnamon/localization-fix

Conversation

@cinnamon-msft
Copy link
Contributor

@cinnamon-msft cinnamon-msft commented Oct 22, 2020

Summary of the Pull Request

Fixes the last bit of missing localization for the settings UI

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

carlos-zamora
carlos-zamora reviewed Oct 22, 2020
View reviewed changes
@carlos-zamora carlos-zamora mentioned this pull request Oct 22, 2020
Closed
34 tasks
@carlos-zamora carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 22, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 25 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Oct 22, 2020

@msftbot merge this in 2 minutes

@ghost
Copy link

ghost commented Oct 22, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 22 Oct 2020 19:04:43 GMT, which is in 2 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 44d16b8 into feature/settings-ui Oct 22, 2020
@ghost ghost deleted the cinnamon/localization-fix branch October 22, 2020 19:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees

No one assigned

Labels

AutoMerge Marked for automatic merge by the bot when requirements are met

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cinnamon-msft @DHowett @carlos-zamora